From: mike stump <mrs@windriver.com>
To: binutils@gcc.gnu.org
Subject: m68k fix request for 2.11.x release branch
Date: Tue, 28 Aug 2001 08:08:00 -0000 [thread overview]
Message-ID: <200108281508.IAA22634@kankakee.wrs.com> (raw)
Below is a patch that is necessary for testcase just below. Could
this be checked in to the 2.11.x release branch? It used to work, but
someone broke it, and then Nick fixed it. The testcase works in the
top of tree. I tested the testcase with the patch in the 2.11.x
release branch, and it seems to work with it.
Thanks.
#NO_APP
.text
Ltext0:
.balign 2
.globl _foobar
_foobar:
.stabd 68,0,242
link a6,#-24
movel d0,d1
movel d1,d0
lsll #2,d0
lea a6@(-44),a0
moveq #110,d1
moveq #110,d1
moveq #110,d1
cmpl a0@(d0:l),d1
jeq L38
jra L39
.balign 2
L39:
jra L37
.balign 2
L38:
.stabd 68,0,362
addql #1,a6@(-4)
jra L36
.balign 2
2001-07-06 Nick Clifton <nickc@cambridge.redhat.com>
* config/tc-m68k.c (md_estimate_size_before_relax): Catch and
ignore empty, ineffectual alignment frags when deciding if a
branch can be short.
Index: tc-m68k.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-m68k.c,v
retrieving revision 1.17.2.2
diff -p -c -r1.17.2.2 tc-m68k.c
*** tc-m68k.c 2001/06/11 10:04:48 1.17.2.2
--- tc-m68k.c 2001/08/28 15:02:33
*************** md_estimate_size_before_relax (fragP, se
*** 4692,4704 ****
fragS *l;
stop = symbol_get_frag (fragP->fr_symbol);
for (l = fragP->fr_next; l != stop; l = l->fr_next)
- if (l->fr_fix + l->fr_var != 0)
- break;
- if (l == stop)
{
! fragP->fr_subtype = TAB (TABTYPE (fragP->fr_subtype), SHORT);
}
}
break;
default:
--- 4692,4716 ----
fragS *l;
stop = symbol_get_frag (fragP->fr_symbol);
+
for (l = fragP->fr_next; l != stop; l = l->fr_next)
{
! /* Catch empty alignment frags whoes fr_offset field
! is an alignment requirement of 2 bytes. The check
! below will misinterpret this as evidence that real
! code exists between the symbol and the instruction
! and so will not convert the short jump into a word
! jump. */
! if (l->fr_fix == 0
! && l->fr_var == 1
! && (l->fr_type == rs_align || l->fr_type == rs_align_code))
! continue;
!
! if (l->fr_fix + l->fr_var != 0)
! break;
}
+ if (l == stop)
+ fragP->fr_subtype = TAB (TABTYPE (fragP->fr_subtype), SHORT);
}
break;
default:
--------------------
next reply other threads:[~2001-08-28 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-28 8:08 mike stump [this message]
2001-08-28 22:26 ` Alan Modra
2001-08-29 11:27 ` Philip Blundell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200108281508.IAA22634@kankakee.wrs.com \
--to=mrs@windriver.com \
--cc=binutils@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).