From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H . J . Lu" To: binutils@sourceware.cygnus.com Subject: PATCH: Fix typo in elf32-mips.c Date: Thu, 30 Aug 2001 08:26:00 -0000 Message-id: <20010830082616.A8061@lucon.org> X-SW-Source: 2001-08/msg00694.html I checked in the following patch as an obvious fix. H.J. ----- 2001-08-30 H.J. Lu * elf32-mips.c (mips_elf_calculate_relocation): Don't create dynamic relocation for undefined weak symbols when creating executables. Check h->root.root.type, instead of h->root.type. --- elf32-mips.c.dynamic Thu Aug 30 08:00:39 2001 +++ elf32-mips.c Thu Aug 30 08:06:21 2001 @@ -6334,7 +6334,8 @@ mips_elf_calculate_relocation (abfd, if ((info->shared || (elf_hash_table (info)->dynamic_sections_created && h != NULL - && (h->root.type == bfd_link_hash_defweak + && h->root.root.type != bfd_link_hash_undefweak + && (h->root.root.type == bfd_link_hash_defweak || (h->root.elf_link_hash_flags & ELF_LINK_HASH_DEF_REGULAR) == 0))) && (input_section->flags & SEC_ALLOC) != 0)