public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@bigpond.net.au>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Nick Clifton <nickc@cambridge.redhat.com>,
	Jakub Jelinek <jakub@redhat.com>,
	binutils@sources.redhat.com, laroche@redhat.com
Subject: Re: s390 gas bug
Date: Tue, 02 Oct 2001 07:34:00 -0000	[thread overview]
Message-ID: <20011003000441.O1019@bubble.sa.bigpond.net.au> (raw)
In-Reply-To: <OF7417AF34.31A110BF-ONC1256AD9.004C537A@de.ibm.com>

On Tue, Oct 02, 2001 at 03:55:43PM +0200, Martin Schwidefsky wrote:
> 
> > > it doesn't create an R_390_PLT32 relocation and instead hardcodes
> > > address of f1 above it. For static int f1 (void) { return 1; } this
> > > would be right, but as f1 is global symbol, it should be possible to
> > > override f1 at runtime
> >
> > Well, for certain file formats, yes.
> >
> > It sounds like the s390 gas port needs to define TC_FORCE_RELOCATION
> > and then have it return true for BFD_RELOC_S390_PLT32 relocs, and
> > probably some others as well.
> 
> Isn't that what tc_fix_adjustable is supposed to catch ?
> 

Well, no, not for this particular case.  You need to define
TC_FORCE_RELOCATION to cover this situation because to the generic
code in write.c:fixup_segment, your "f1@PLT-.LT1_0" expression
looks like the subtraction of two syms in one segment.  The normal
action is to perform the subtraction and not emit a reloc.

Alan

  reply	other threads:[~2001-10-02  7:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-02  6:58 Martin Schwidefsky
2001-10-02  7:34 ` Alan Modra [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-10-18  1:02 Martin Schwidefsky
2001-10-31 10:57 Martin Schwidefsky
2001-10-04  6:21 Martin Schwidefsky
2001-10-04  4:35 Martin Schwidefsky
2001-10-04  6:04 ` Alan Modra
2001-10-14  2:48   ` Andreas Jaeger
2001-10-02  5:15 Jakub Jelinek
2001-10-02  6:38 ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011003000441.O1019@bubble.sa.bigpond.net.au \
    --to=amodra@bigpond.net.au \
    --cc=binutils@sources.redhat.com \
    --cc=jakub@redhat.com \
    --cc=laroche@redhat.com \
    --cc=nickc@cambridge.redhat.com \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).