[RFA:] toplevel/Makefile.in: Let install depend on install-info

[RFA:] toplevel/Makefile.in: Let install depend on install-info

[Hans-Peter Nilsson]

(GCC is the master source, asking for approval to commit in both
trees.)

The GNU coding standards say everything, including info pages,
is to be installed with "make install", but right now (and
including binutils-2.11.2) the installer must perform a separate
"make install-info" to make this happen for info pages.

GCC does not see this problem because it has a separate
"install: install-info" dependency in gcc/Makefile.in, but that
doesn't help binutils.  (And that dependency should probably go
with this or equivalent patch applied.)

This isn't an automake issue as one might think, because
subdirectories (such as gas/doc/Makefile.am) use the --cygnus
automake option, which as one of its documented effects causes
"install-info" to not be implied by "install".

Tested by checking that "make install" in binutils toplevel
from scratch causes info pages to now be installed.

Ok to commit?

toplevel:

	* Makefile.in (install): Depend on install-info.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/Makefile.in,v
retrieving revision 1.43
diff -p -c -r1.43 Makefile.in
*** Makefile.in	2001/11/28 19:55:01	1.43
--- Makefile.in	2002/01/01 23:36:39
*************** mail-report-with-warnings.log: warning.l
*** 1148,1154 ****
  # Installation targets.

  .PHONY: install install-cross uninstall source-vault binary-vault vault-install
! install: $(INSTALL_TARGET)
  install-cross: $(INSTALL_TARGET_CROSS)

  uninstall:
--- 1148,1154 ----
  # Installation targets.

  .PHONY: install install-cross uninstall source-vault binary-vault vault-install
! install: install-info $(INSTALL_TARGET)
  install-cross: $(INSTALL_TARGET_CROSS)

  uninstall:

brgds, H-P

Re: [RFA:] toplevel/Makefile.in: Let install depend on install-info

[DJ Delorie]

> This isn't an automake issue as one might think, because
> subdirectories (such as gas/doc/Makefile.am) use the --cygnus
> automake option, which as one of its documented effects causes
> "install-info" to not be implied by "install".

Then the right solution is to fix the subdirectories, so that "make
install" there also installs info pages.  Otherwise, even with your
patch they won't meed GNU standards.  And if you do fix them, then
your patch shouldn't be needed.

I don't think the toplevel Makefile should be doing anything more
complicated than passing the given target down to the subdirectories
(aside from the complexity of doing the subdirectories in the right
order).  If the user says "make install" then that's what ./Makefile
should do - invoke "make install" in all the subdirectories.

Plus, with your patch, any subdirectory that does it right is punished
by having to install the info files twice.