public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@bigpond.net.au>
To: binutils@sources.redhat.com
Subject: XCOFF/PE hack removal
Date: Tue, 22 Jan 2002 01:54:00 -0000	[thread overview]
Message-ID: <20020122091547.GO16187@bubble.sa.bigpond.net.au> (raw)

I'd like to apply the following so that errors reported when linking
powerpc64-elf objects discern between a function descriptor symbol
and it's associated function code symbol, which only differs by a
leading dot.  However, this will affect PE and XCOFF error messages,
so I'd like an OK from the opposition camp first.  If not OK, then
I'll do something target dependent.

ld/ChangeLog
	* ldmisc.c (demangle): Put back dots when string not demangled.
 
-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Index: ld/ldmisc.c
===================================================================
RCS file: /cvs/src/src/ld/ldmisc.c,v
retrieving revision 1.8
diff -u -p -r1.8 ldmisc.c
--- ldmisc.c	2001/09/26 01:55:44	1.8
+++ ldmisc.c	2002/01/22 09:08:55
@@ -69,6 +69,7 @@ demangle (string)
      const char *string;
 {
   char *res;
+  int dots = 0;
 
   if (output_bfd != NULL
       && bfd_get_symbol_leading_char (output_bfd) == string[0])
@@ -78,9 +79,13 @@ demangle (string)
      format.  Xcoff has a single '.', while the NT PE for PPC has
      '..'.  So we remove all of them.  */
   while (string[0] == '.')
-    ++string;
+    {
+      ++dots;
+      ++string;
+    }
 
   res = cplus_demangle (string, DMGL_ANSI | DMGL_PARAMS);
+  string -= dots;
   return res ? res : xstrdup (string);
 }

             reply	other threads:[~2002-01-22  9:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-22  1:54 Alan Modra [this message]
2002-01-22 11:10 ` Tom Rix
2002-01-25  5:04   ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020122091547.GO16187@bubble.sa.bigpond.net.au \
    --to=amodra@bigpond.net.au \
    --cc=binutils@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).