From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4263 invoked by alias); 29 Jan 2002 19:16:58 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 4219 invoked from network); 29 Jan 2002 19:16:55 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 29 Jan 2002 19:16:55 -0000 Received: from drow by nevyn.them.org with local (Exim 3.34 #1 (Debian)) id 16VdkZ-0000hb-00 for ; Tue, 29 Jan 2002 14:16:59 -0500 Date: Tue, 29 Jan 2002 11:45:00 -0000 From: Daniel Jacobowitz To: binutils@sources.redhat.com Subject: Re: [RFA] A missing ATTRIBUTE_UNUSED Message-ID: <20020129141659.A2426@nevyn.them.org> Mail-Followup-To: binutils@sources.redhat.com References: <20020129120435.A25902@nevyn.them.org> <3C56EF3A.1080302@cygnus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3C56EF3A.1080302@cygnus.com> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-01/txt/msg00625.txt.bz2 On Tue, Jan 29, 2002 at 01:51:38PM -0500, Andrew Cagney wrote: > >What's the policy on functions that conditionally use their arguments? I > >couldn't find another example offhand, so I don't know if this patch is > >right. > > > >With this one I can do most of a -Werror build again. > > > Have a look in BFD :-) > > BINUTILS uses ATTRIBUTE_UNUSED. GDB uses -Wno-unused-params. This is conditionally unused, according to conditional compilation; that's what I couldn't find an example of. I think it's fine, though. I understand GDB's reason for not using it, and I think that perhaps we should instead have pushed for new attributes that provide the functionality GDB wants. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer