public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Philipp Thomas <pthomas@suse.de>
To: Nick Clifton <nickc@redhat.com>
Cc: binutils@sources.redhat.com
Subject: Possibly unnecessary differences in messages
Date: Tue, 29 Jan 2002 10:04:00 -0000	[thread overview]
Message-ID: <20020129181350.I15749@jeffreys.suse.de> (raw)

Nick,

elf32_arm_copy_private_bfd_data in bfd/elf32-arm.h at line 2161 has this
code:

      /* If the src and dest have different interworking flags
         then turn off the interworking bit.  */
      if ((in_flags & EF_ARM_INTERWORK) != (out_flags & EF_ARM_INTERWORK))
        {
          if (out_flags & EF_ARM_INTERWORK)
            _bfd_error_handler (_("\
Warning: Clearing the interwork flag in %s because non-interworking code in %s has been linked with it"),
                                bfd_get_filename (obfd),
                                bfd_archive_filename (ibfd));

and coff_arm_copy_private_bfd_data in bfd/coff-arm.c at line 2457 has:

          /* If the src and dest have different interworking flags then turn
             off the interworking bit.  */
          if (INTERWORK_FLAG (dest) != INTERWORK_FLAG (src))
            {
              if (INTERWORK_FLAG (dest))
                {
                  /* xgettext:c-format */
                  _bfd_error_handler (("Warning: Clearing the interworking bit of %s, because the non-interworking code in %s has been copied into it"),
                                      bfd_get_filename (dest),
                                      bfd_archive_filename (src));


As far as I can tell (I have nearly no knowledge of ARM), the code does the same
thing and only uses slightly different wording for the message, correct? If
so, the messages should be identical, and the only question would be which
of the two should be used.

BTW, at least the messages dealing with the interwork flag differ slightly between
elf32-arm.h and coff-arm.c. One example is in the above snippets which use
'interworking flag' and 'interwork flag' respectively. I'd also like to get
those messages in sync if that's OK with you. If yes, should I use interwork
flag or interworking flag.

All those changes would make translating easier as identical messages get
merged in the master message catalog.

Philipp

-- 
Philipp Thomas <pthomas@suse.de>
SuSE Linux AG, Deutscherrnstr. 15-19, D-90429 Nuremberg, Germany

             reply	other threads:[~2002-01-29 17:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-29 10:04 Philipp Thomas [this message]
2002-01-29 11:16 ` Richard Earnshaw
2002-01-30  6:08   ` Philipp Thomas
2002-01-30  6:12     ` Richard Earnshaw
2002-01-30  6:15   ` [PATCH] Unify messages in coff-arm.c and elf32-arm.h Philipp Thomas
2002-01-30  6:21     ` Richard Earnshaw
2002-01-30  6:24       ` Richard Earnshaw
2002-01-30  6:53         ` Philipp Thomas
2002-01-30  8:41           ` Richard Earnshaw
2002-01-30  9:05             ` Philipp Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020129181350.I15749@jeffreys.suse.de \
    --to=pthomas@suse.de \
    --cc=binutils@sources.redhat.com \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).