[RFA] A missing ATTRIBUTE_UNUSED

[RFA] A missing ATTRIBUTE_UNUSED

[Daniel Jacobowitz]

What's the policy on functions that conditionally use their arguments?  I
couldn't find another example offhand, so I don't know if this patch is
right.

With this one I can do most of a -Werror build again.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

2002-01-29  Daniel Jacobowitz  <drow@mvista.com>

	* nm.c (print_value): Mark abfd unused.

Index: nm.c
===================================================================
RCS file: /cvs/src/src/binutils/nm.c,v
retrieving revision 1.18
diff -u -r1.18 nm.c
--- nm.c	2002/01/23 16:12:55	1.18
+++ nm.c	2002/01/29 17:02:10
@@ -1453,7 +1453,7 @@
 
 static void
 print_value (abfd, val)
-     bfd *abfd;
+     bfd *abfd ATTRIBUTE_UNUSED;
      bfd_vma val;
 {
 #if ! defined (BFD64) || BFD_HOST_64BIT_LONG

Re: [RFA] A missing ATTRIBUTE_UNUSED

[Andrew Cagney]

> What's the policy on functions that conditionally use their arguments?  I
> couldn't find another example offhand, so I don't know if this patch is
> right.
> 
> With this one I can do most of a -Werror build again.


Have a look in BFD :-)

BINUTILS uses ATTRIBUTE_UNUSED.  GDB uses -Wno-unused-params.

enjoy,
Andrew

Re: [RFA] A missing ATTRIBUTE_UNUSED

[Daniel Jacobowitz]

On Tue, Jan 29, 2002 at 01:51:38PM -0500, Andrew Cagney wrote:
> >What's the policy on functions that conditionally use their arguments?  I
> >couldn't find another example offhand, so I don't know if this patch is
> >right.
> >
> >With this one I can do most of a -Werror build again.
> 
> 
> Have a look in BFD :-)
> 
> BINUTILS uses ATTRIBUTE_UNUSED.  GDB uses -Wno-unused-params.

This is conditionally unused, according to conditional compilation;
that's what I couldn't find an example of.  I think it's fine, though.

I understand GDB's reason for not using it, and I think that perhaps we
should instead have pushed for new attributes that provide the
functionality GDB wants.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Re: [RFA] A missing ATTRIBUTE_UNUSED

[Alan Modra]

On Tue, Jan 29, 2002 at 02:16:59PM -0500, Daniel Jacobowitz wrote:
> 
> This is conditionally unused, according to conditional compilation;
> that's what I couldn't find an example of.  I think it's fine, though.

I'd do exactly as you did.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Re: [RFA] A missing ATTRIBUTE_UNUSED

[Daniel Jacobowitz]

On Wed, Jan 30, 2002 at 11:59:10AM +1030, Alan Modra wrote:
> On Tue, Jan 29, 2002 at 02:16:59PM -0500, Daniel Jacobowitz wrote:
> > 
> > This is conditionally unused, according to conditional compilation;
> > that's what I couldn't find an example of.  I think it's fine, though.
> 
> I'd do exactly as you did.

Committed as is then.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer