* [PATCH] SHF_MERGE fix
@ 2002-03-04 7:17 Jakub Jelinek
2002-03-04 15:46 ` Alan Modra
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2002-03-04 7:17 UTC (permalink / raw)
To: binutils
Hi!
If GC removes all input sections with the same name, SHF_STRINGS setting
and sh_entsize, we would segfault...
Ok to commit?
2002-03-04 Jakub Jelinek <jakub@redhat.com>
* merge.c (_bfd_merge_sections): Don't segfault if there
is nothing to merge due to GC.
--- bfd/merge.c.jj Mon Jan 14 17:53:10 2002
+++ bfd/merge.c Mon Mar 4 16:20:55 2002
@@ -804,6 +804,9 @@ _bfd_merge_sections (abfd, xsinfo, remov
if (secinfo)
continue;
+ if (sinfo->htab->first == NULL)
+ continue;
+
if (sinfo->htab->strings)
merge_strings (sinfo);
else
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] SHF_MERGE fix
2002-03-04 7:17 [PATCH] SHF_MERGE fix Jakub Jelinek
@ 2002-03-04 15:46 ` Alan Modra
0 siblings, 0 replies; 2+ messages in thread
From: Alan Modra @ 2002-03-04 15:46 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: binutils
On Mon, Mar 04, 2002 at 04:16:50PM +0100, Jakub Jelinek wrote:
>
> * merge.c (_bfd_merge_sections): Don't segfault if there
> is nothing to merge due to GC.
merge.c is your baby. No need to ask permission to commit.
--
Alan Modra
IBM OzLabs - Linux Technology Centre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-03-04 23:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-03-04 7:17 [PATCH] SHF_MERGE fix Jakub Jelinek
2002-03-04 15:46 ` Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).