From: "H. J. Lu" <hjl@lucon.org>
To: davidm@hpl.hp.com, binutils@sources.redhat.com
Subject: Re: [patch] important performance bug fix
Date: Tue, 16 Jul 2002 22:02:00 -0000 [thread overview]
Message-ID: <20020716214914.A1444@lucon.org> (raw)
In-Reply-To: <20020717023440.GA10190@nevyn.them.org>; from drow@mvista.com on Tue, Jul 16, 2002 at 10:34:40PM -0400
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
On Tue, Jul 16, 2002 at 10:34:40PM -0400, Daniel Jacobowitz wrote:
> On Tue, Jul 16, 2002 at 07:19:53PM -0700, H. J. Lu wrote:
> > On Tue, Jul 16, 2002 at 06:57:47PM -0700, David Mosberger wrote:
> > > I haven't received any feedback regarding the bug & patch reported in:
> > >
> > > http://sources.redhat.com/ml/binutils/2002-07/msg00268.html
> > >
> > > Would someone be so kind to either check in the patch or let me know
> > > what's wrong with it?
> >
> > Why not check it in? David will be among the first to know when
> > something is broken on ia64 :-). David, could you please resend it to
> > me? I will check it in for you.
>
> How about because he isn't the ia64 maintainer? No offense meant to
> David, since I actually trust his judgement, but the patch looks too
> large to my eye to call "obvious", and it hasn't been approved yet.
>
David will be the first, if not the only, one affected by his ia64
change. I will check in his patch along with the gas testsuite change
enlosed here after I finish "make check" in the combined gcc 3.1
and binutils tree on ia64.
David, could you please double check my gas patch?
Thanks.
H.J.
[-- Attachment #2: gas-ia64.patch --]
[-- Type: text/plain, Size: 9507 bytes --]
2002-07-16 H.J. Lu <hjl@gnu.org>
* gas/ia64/dv-branch.d: Updated.
* gas/ia64/opc-b.d: Likewise.
--- testsuite/gas/ia64/dv-branch.d.ia64 Sun Apr 23 09:41:25 2000
+++ testsuite/gas/ia64/dv-branch.d Tue Jul 16 21:33:14 2002
@@ -9,7 +9,7 @@ Disassembly of section \.text:
0000000000000000 <\.text>:
0: d0 08 00 10 18 90 \[MIB\] \(p06\) ld8 r1=\[r8\]
6: 61 10 04 80 03 03 \(p06\) mov b6=r2
- c: 68 00 00 10 \(p06\) br\.call\.sptk\.many b0=b6
+ c: 68 00 80 10 \(p06\) br\.call\.sptk\.many b0=b6
10: 11 08 00 3c 00 21 \[MIB\] mov r1=r30
16: 00 00 00 02 00 03 nop\.i 0x0
1c: f0 ff ff 48 \(p06\) br\.cond\.sptk\.few 0x0;;
--- testsuite/gas/ia64/opc-b.d.ia64 Sun Apr 23 09:41:25 2000
+++ testsuite/gas/ia64/opc-b.d Tue Jul 16 21:34:21 2002
@@ -871,77 +871,77 @@ Disassembly of section .text:
11f6: 40 14 00 c2 03 80 \(p02\) br\.ret\.dpnt\.many\.clr b2
11fc: 28 00 84 07 br\.ret\.dpnt\.many\.clr b2;;
1200: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1206: 00 10 00 00 08 00 \(p02\) br\.call\.sptk\.few b0=b2
- 120c: 20 00 00 10 br\.call\.sptk\.few b0=b2;;
+ 1206: 00 10 00 40 08 00 \(p02\) br\.call\.sptk\.few b0=b2
+ 120c: 20 00 80 10 br\.call\.sptk\.few b0=b2;;
1210: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1216: 00 10 00 00 0a 00 \(p02\) br\.call\.sptk\.few\.clr b0=b2
- 121c: 20 00 00 14 br\.call\.sptk\.few\.clr b0=b2;;
+ 1216: 00 10 00 40 0a 00 \(p02\) br\.call\.sptk\.few\.clr b0=b2
+ 121c: 20 00 80 14 br\.call\.sptk\.few\.clr b0=b2;;
1220: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1226: 00 10 00 00 08 00 \(p02\) br\.call\.sptk\.few b0=b2
- 122c: 20 00 00 10 br\.call\.sptk\.few b0=b2;;
+ 1226: 00 10 00 40 08 00 \(p02\) br\.call\.sptk\.few b0=b2
+ 122c: 20 00 80 10 br\.call\.sptk\.few b0=b2;;
1230: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1236: 00 10 00 00 0a 00 \(p02\) br\.call\.sptk\.few\.clr b0=b2
- 123c: 20 00 00 14 br\.call\.sptk\.few\.clr b0=b2;;
+ 1236: 00 10 00 40 0a 00 \(p02\) br\.call\.sptk\.few\.clr b0=b2
+ 123c: 20 00 80 14 br\.call\.sptk\.few\.clr b0=b2;;
1240: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1246: 00 14 00 00 08 00 \(p02\) br\.call\.sptk\.many b0=b2
- 124c: 28 00 00 10 br\.call\.sptk\.many b0=b2;;
+ 1246: 00 14 00 40 08 00 \(p02\) br\.call\.sptk\.many b0=b2
+ 124c: 28 00 80 10 br\.call\.sptk\.many b0=b2;;
1250: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1256: 00 14 00 00 0a 00 \(p02\) br\.call\.sptk\.many\.clr b0=b2
- 125c: 28 00 00 14 br\.call\.sptk\.many\.clr b0=b2;;
+ 1256: 00 14 00 40 0a 00 \(p02\) br\.call\.sptk\.many\.clr b0=b2
+ 125c: 28 00 80 14 br\.call\.sptk\.many\.clr b0=b2;;
1260: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1266: 00 10 00 80 08 00 \(p02\) br\.call\.spnt\.few b0=b2
- 126c: 20 00 00 11 br\.call\.spnt\.few b0=b2;;
+ 1266: 00 10 00 c0 08 00 \(p02\) br\.call\.spnt\.few b0=b2
+ 126c: 20 00 80 11 br\.call\.spnt\.few b0=b2;;
1270: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1276: 00 10 00 80 0a 00 \(p02\) br\.call\.spnt\.few\.clr b0=b2
- 127c: 20 00 00 15 br\.call\.spnt\.few\.clr b0=b2;;
+ 1276: 00 10 00 c0 0a 00 \(p02\) br\.call\.spnt\.few\.clr b0=b2
+ 127c: 20 00 80 15 br\.call\.spnt\.few\.clr b0=b2;;
1280: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1286: 00 10 00 80 08 00 \(p02\) br\.call\.spnt\.few b0=b2
- 128c: 20 00 00 11 br\.call\.spnt\.few b0=b2;;
+ 1286: 00 10 00 c0 08 00 \(p02\) br\.call\.spnt\.few b0=b2
+ 128c: 20 00 80 11 br\.call\.spnt\.few b0=b2;;
1290: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1296: 00 10 00 80 0a 00 \(p02\) br\.call\.spnt\.few\.clr b0=b2
- 129c: 20 00 00 15 br\.call\.spnt\.few\.clr b0=b2;;
+ 1296: 00 10 00 c0 0a 00 \(p02\) br\.call\.spnt\.few\.clr b0=b2
+ 129c: 20 00 80 15 br\.call\.spnt\.few\.clr b0=b2;;
12a0: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 12a6: 00 14 00 80 08 00 \(p02\) br\.call\.spnt\.many b0=b2
- 12ac: 28 00 00 11 br\.call\.spnt\.many b0=b2;;
+ 12a6: 00 14 00 c0 08 00 \(p02\) br\.call\.spnt\.many b0=b2
+ 12ac: 28 00 80 11 br\.call\.spnt\.many b0=b2;;
12b0: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 12b6: 00 14 00 80 0a 00 \(p02\) br\.call\.spnt\.many\.clr b0=b2
- 12bc: 28 00 00 15 br\.call\.spnt\.many\.clr b0=b2;;
+ 12b6: 00 14 00 c0 0a 00 \(p02\) br\.call\.spnt\.many\.clr b0=b2
+ 12bc: 28 00 80 15 br\.call\.spnt\.many\.clr b0=b2;;
12c0: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 12c6: 00 10 00 00 09 00 \(p02\) br\.call\.dptk\.few b0=b2
- 12cc: 20 00 00 12 br\.call\.dptk\.few b0=b2;;
+ 12c6: 00 10 00 40 09 00 \(p02\) br\.call\.dptk\.few b0=b2
+ 12cc: 20 00 80 12 br\.call\.dptk\.few b0=b2;;
12d0: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 12d6: 00 10 00 00 0b 00 \(p02\) br\.call\.dptk\.few\.clr b0=b2
- 12dc: 20 00 00 16 br\.call\.dptk\.few\.clr b0=b2;;
+ 12d6: 00 10 00 40 0b 00 \(p02\) br\.call\.dptk\.few\.clr b0=b2
+ 12dc: 20 00 80 16 br\.call\.dptk\.few\.clr b0=b2;;
12e0: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 12e6: 00 10 00 00 09 00 \(p02\) br\.call\.dptk\.few b0=b2
- 12ec: 20 00 00 12 br\.call\.dptk\.few b0=b2;;
+ 12e6: 00 10 00 40 09 00 \(p02\) br\.call\.dptk\.few b0=b2
+ 12ec: 20 00 80 12 br\.call\.dptk\.few b0=b2;;
12f0: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 12f6: 00 10 00 00 0b 00 \(p02\) br\.call\.dptk\.few\.clr b0=b2
- 12fc: 20 00 00 16 br\.call\.dptk\.few\.clr b0=b2;;
+ 12f6: 00 10 00 40 0b 00 \(p02\) br\.call\.dptk\.few\.clr b0=b2
+ 12fc: 20 00 80 16 br\.call\.dptk\.few\.clr b0=b2;;
1300: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1306: 00 14 00 00 09 00 \(p02\) br\.call\.dptk\.many b0=b2
- 130c: 28 00 00 12 br\.call\.dptk\.many b0=b2;;
+ 1306: 00 14 00 40 09 00 \(p02\) br\.call\.dptk\.many b0=b2
+ 130c: 28 00 80 12 br\.call\.dptk\.many b0=b2;;
1310: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1316: 00 14 00 00 0b 00 \(p02\) br\.call\.dptk\.many\.clr b0=b2
- 131c: 28 00 00 16 br\.call\.dptk\.many\.clr b0=b2;;
+ 1316: 00 14 00 40 0b 00 \(p02\) br\.call\.dptk\.many\.clr b0=b2
+ 131c: 28 00 80 16 br\.call\.dptk\.many\.clr b0=b2;;
1320: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1326: 00 10 00 80 09 00 \(p02\) br\.call\.dpnt\.few b0=b2
- 132c: 20 00 00 13 br\.call\.dpnt\.few b0=b2;;
+ 1326: 00 10 00 c0 09 00 \(p02\) br\.call\.dpnt\.few b0=b2
+ 132c: 20 00 80 13 br\.call\.dpnt\.few b0=b2;;
1330: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1336: 00 10 00 80 0b 00 \(p02\) br\.call\.dpnt\.few\.clr b0=b2
- 133c: 20 00 00 17 br\.call\.dpnt\.few\.clr b0=b2;;
+ 1336: 00 10 00 c0 0b 00 \(p02\) br\.call\.dpnt\.few\.clr b0=b2
+ 133c: 20 00 80 17 br\.call\.dpnt\.few\.clr b0=b2;;
1340: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1346: 00 10 00 80 09 00 \(p02\) br\.call\.dpnt\.few b0=b2
- 134c: 20 00 00 13 br\.call\.dpnt\.few b0=b2;;
+ 1346: 00 10 00 c0 09 00 \(p02\) br\.call\.dpnt\.few b0=b2
+ 134c: 20 00 80 13 br\.call\.dpnt\.few b0=b2;;
1350: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1356: 00 10 00 80 0b 00 \(p02\) br\.call\.dpnt\.few\.clr b0=b2
- 135c: 20 00 00 17 br\.call\.dpnt\.few\.clr b0=b2;;
+ 1356: 00 10 00 c0 0b 00 \(p02\) br\.call\.dpnt\.few\.clr b0=b2
+ 135c: 20 00 80 17 br\.call\.dpnt\.few\.clr b0=b2;;
1360: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1366: 00 14 00 80 09 00 \(p02\) br\.call\.dpnt\.many b0=b2
- 136c: 28 00 00 13 br\.call\.dpnt\.many b0=b2;;
+ 1366: 00 14 00 c0 09 00 \(p02\) br\.call\.dpnt\.many b0=b2
+ 136c: 28 00 80 13 br\.call\.dpnt\.many b0=b2;;
1370: 17 00 00 00 00 88 \[BBB\] nop\.b 0x0
- 1376: 00 14 00 80 0b 00 \(p02\) br\.call\.dpnt\.many\.clr b0=b2
- 137c: 28 00 00 17 br\.call\.dpnt\.many\.clr b0=b2;;
+ 1376: 00 14 00 c0 0b 00 \(p02\) br\.call\.dpnt\.many\.clr b0=b2
+ 137c: 28 00 80 17 br\.call\.dpnt\.many\.clr b0=b2;;
1380: 17 00 00 00 00 00 \[BBB\] break\.b 0x0
1386: 00 00 00 00 10 40 nop\.b 0x0
138c: 80 ec ff 78 brp\.sptk 0x0,0x13a0;;
next prev parent reply other threads:[~2002-07-17 4:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-16 19:19 David Mosberger
2002-07-16 19:25 ` H. J. Lu
2002-07-16 21:18 ` Daniel Jacobowitz
2002-07-16 22:02 ` H. J. Lu [this message]
2002-07-17 0:15 ` David Mosberger
2002-07-17 0:58 ` H. J. Lu
2002-07-17 0:29 ` David Mosberger
2002-07-17 12:57 ` Jim Wilson
2002-07-17 14:05 ` David Mosberger
-- strict thread matches above, loose matches on Subject: below --
2002-07-12 18:51 David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020716214914.A1444@lucon.org \
--to=hjl@lucon.org \
--cc=binutils@sources.redhat.com \
--cc=davidm@hpl.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).