public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "John David Anglin" <dave@hiauly1.hia.nrc.ca>
To: amodra@bigpond.net.au (Alan Modra)
Cc: binutils@sources.redhat.com
Subject: Re: K&R patch for binutils bfd directory
Date: Thu, 24 Oct 2002 19:35:00 -0000	[thread overview]
Message-ID: <200210250235.g9P2ZEgW027426@hiauly1.hia.nrc.ca> (raw)
In-Reply-To: <20021025021248.GE12686@bubble.sa.bigpond.net.au> from "Alan Modra" at Oct 25, 2002 11:42:48 am

> OK.  It offends my sense of style to see something like
> 
> 	copy = (boolean) (! finfo->info->keep_memory);

Yes, it's definitely ugly especially since the underlying implementation
is int.  I guess the thought was that enums have only a limited set of
values, so when an int is assigned to enum there should be a warning since
the value might not be in the set.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6605)

  reply	other threads:[~2002-10-25  2:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-24 16:00 John David Anglin
2002-10-24 16:20 ` Andrew Cagney
2002-10-25  7:32   ` `true' and `false'; Was: " Andrew Cagney
2002-10-24 19:12 ` Alan Modra
2002-10-24 19:35   ` John David Anglin [this message]
     [not found] <no.id>
2002-10-24 19:42 ` John David Anglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200210250235.g9P2ZEgW027426@hiauly1.hia.nrc.ca \
    --to=dave@hiauly1.hia.nrc.ca \
    --cc=amodra@bigpond.net.au \
    --cc=binutils@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).