public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* A mips n32/n64 gas bug?
@ 2003-03-12 17:52 H. J. Lu
  0 siblings, 0 replies; only message in thread
From: H. J. Lu @ 2003-03-12 17:52 UTC (permalink / raw)
  To: binutils

Does this make any senses?


H.J.
----
--- gas/config/tc-mips.c.gprel	
+++ gas/config/tc-mips.c
@@ -13396,7 +13396,16 @@ tc_gen_reloc (section, fixp)
       && (code == BFD_RELOC_GPREL16 || code == BFD_RELOC_MIPS16_GPREL)
       && reloc->addend != 0
       && mips_need_elf_addend_fixup (fixp))
-    reloc->addend += S_GET_VALUE (fixp->fx_addsy);
+    {
+      /* In o32 GPREL16 is always inplace, but in n32 and 64
+         it isn't. I wish someone would get rid of this "fix". */
+      reloc_howto_type *howto;
+
+      howto = bfd_reloc_type_lookup (stdoutput, fixp->fx_r_type);
+      if (howto->partial_inplace) {
+       reloc->addend += S_GET_VALUE (fixp->fx_addsy);
+      }
+    }
 #endif
 
   /* To support a PC relative reloc when generating embedded PIC code

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-03-12 17:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-12 17:52 A mips n32/n64 gas bug? H. J. Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).