Patch to correct bucomm.c mktemp usage

Patch to correct bucomm.c mktemp usage

[J. Grant]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

Hello,

Use of mktemp here generates a statement when compiling, this patch 
corrects the issue. (unless mktemp() is required instead of mkstemp() 
for a reason I am unaware).

2003-03-14  J. Grant  <jg-binutils@jguk.org>

	* bucomm.c: Change mktemp to mkstemp.


Please include my email address in any replies.

Regards

JG

[-- Attachment #2: bucomm-01.patch --]
[-- Type: text/plain, Size: 451 bytes --]

--- bucomm.c.orig	2002-10-28 16:01:19.000000000 +0000
+++ bucomm.c	2003-03-12 12:52:16.000000000 +0000
@@ -235,14 +235,14 @@
 #endif
       strcat (tmpname, "/");
       strcat (tmpname, template);
-      mktemp (tmpname);
+      mkstemp (tmpname);
       *slash = c;
     }
   else
     {
       tmpname = xmalloc (sizeof (template));
       strcpy (tmpname, template);
-      mktemp (tmpname);
+      mkstemp (tmpname);
     }
   return tmpname;
 }

Re: Patch to correct bucomm.c mktemp usage

[DJ Delorie]

> Use of mktemp here generates a statement when compiling, this patch 
> corrects the issue. (unless mktemp() is required instead of mkstemp() 
> for a reason I am unaware).

There is a reason of which you are unaware.

2001-11-29  H.J. Lu <hjl@gnu.org>

        * bucomm.c (make_tempname): Revert the changes made on
        2001-11-14 and 2001-11-12. They won't work with directories.

2001-11-14  Nick Clifton  <nickc@cambridge.redhat.com>

        * bucomm.c (make_tempname): Use mkstemps instead of mkstemp, since
        not all systems provide mkstemp.

2001-11-12  * Steven J. Hill <sjhill@realitydiluted.com>

        * bucomm.c (make_tempname): Use mkstemp in place of mktemp.

Re: Patch to correct bucomm.c mktemp usage

[Ben Elliston]

DJ Delorie <dj@delorie.com> writes:

> > Use of mktemp here generates a statement when compiling, this patch 
> > corrects the issue. (unless mktemp() is required instead of mkstemp() 
> > for a reason I am unaware).

> There is a reason of which you are unaware.

I can imagine that portability of mkstemp() is also a concern.

Ben