public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [patch] toplevel Makefile.tpl cleanup 6/n
@ 2003-03-07  2:26 Nathanael Nerode
  2003-03-12 19:16 ` Alexandre Oliva
  2003-03-14 20:29 ` DJ Delorie
  0 siblings, 2 replies; 3+ messages in thread
From: Nathanael Nerode @ 2003-03-07  2:26 UTC (permalink / raw)
  To: gcc-patches, gdb-patches, binutils

Obvious rearrangement and commenting; it's best if these are right up 
top where they're easily identified.

	* Makefile.tpl: Move .NOEXPORT, MAKEOVERRIDES up.
	* Makefile.in: Regenerate.

--- Makefile.tpl.old	2003-02-28 13:05:21.000000000 -0500
+++ Makefile.tpl	2003-02-28 16:40:56.000000000 -0500
@@ -23,6 +23,10 @@
 # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
 #
 
+# Don't pass command-line variables to submakes.
+.NOEXPORT:
+MAKEOVERRIDES=
+
 # -------------------------------
 # Standard Autoconf-set variables
 # -------------------------------
@@ -1425,7 +1429,3 @@
 AUTOCONF = autoconf
 $(srcdir)/configure: @MAINT@ $(srcdir)/configure.in $(srcdir)/config/acx.m4
 	cd $(srcdir) && $(AUTOCONF)
-#
-
-.NOEXPORT:
-MAKEOVERRIDES=

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] toplevel Makefile.tpl cleanup 6/n
  2003-03-07  2:26 [patch] toplevel Makefile.tpl cleanup 6/n Nathanael Nerode
@ 2003-03-12 19:16 ` Alexandre Oliva
  2003-03-14 20:29 ` DJ Delorie
  1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Oliva @ 2003-03-12 19:16 UTC (permalink / raw)
  To: Nathanael Nerode; +Cc: gcc-patches, gdb-patches, binutils

On Mar  6, 2003, Nathanael Nerode <neroden@twcny.rr.com> wrote:

> 	* Makefile.tpl: Move .NOEXPORT, MAKEOVERRIDES up.
> 	* Makefile.in: Regenerate.

Ok

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                 aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] toplevel Makefile.tpl cleanup 6/n
  2003-03-07  2:26 [patch] toplevel Makefile.tpl cleanup 6/n Nathanael Nerode
  2003-03-12 19:16 ` Alexandre Oliva
@ 2003-03-14 20:29 ` DJ Delorie
  1 sibling, 0 replies; 3+ messages in thread
From: DJ Delorie @ 2003-03-14 20:29 UTC (permalink / raw)
  To: neroden; +Cc: gcc-patches, gdb-patches, binutils


> Obvious rearrangement and commenting; it's best if these are right up 
> top where they're easily identified.
> 
> 	* Makefile.tpl: Move .NOEXPORT, MAKEOVERRIDES up.
> 	* Makefile.in: Regenerate.

This one turns out to be wrong.  .NOEXPORT: is a target.  You made it
the first target.  Now if you type "make" (except for GNU make) it
rebuilds the file ".NOEXPORT" and quits.

Please move the pseudo-targets down past the first real target.  Given
that top-of-file is bad, bottom-of-file is probably the next best
place (i.e. where they started out from).

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-03-14 20:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-07  2:26 [patch] toplevel Makefile.tpl cleanup 6/n Nathanael Nerode
2003-03-12 19:16 ` Alexandre Oliva
2003-03-14 20:29 ` DJ Delorie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).