* PATCH elf.c LP64 'comparsion is always false'
@ 2003-05-08 20:11 Andrey Petrov
2003-05-09 11:00 ` Alan Modra
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Petrov @ 2003-05-08 20:11 UTC (permalink / raw)
To: binutils
This happens on LP64 platform (sparc64 in my case, but I think any).
The patch is trivial.
Andrey
Index: elf.c
===================================================================
RCS file: /cvs/src/src/bfd/elf.c,v
retrieving revision 1.182
diff -u -p -r1.182 elf.c
--- elf.c 24 Apr 2003 17:19:37 -0000 1.182
+++ elf.c 8 May 2003 19:03:22 -0000
@@ -2365,9 +2365,9 @@ elf_fake_sections (abfd, asect, failedpt
this_hdr = &elf_section_data (asect)->this_hdr;
- this_hdr->sh_name = (unsigned long) _bfd_elf_strtab_add (elf_shstrtab (abfd),
+ this_hdr->sh_name = (unsigned int) _bfd_elf_strtab_add (elf_shstrtab (abfd),
asect->name, FALSE);
- if (this_hdr->sh_name == (unsigned long) -1)
+ if (this_hdr->sh_name == (unsigned int) -1)
{
*failedptr = TRUE;
return;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PATCH elf.c LP64 'comparsion is always false'
2003-05-08 20:11 PATCH elf.c LP64 'comparsion is always false' Andrey Petrov
@ 2003-05-09 11:00 ` Alan Modra
0 siblings, 0 replies; 2+ messages in thread
From: Alan Modra @ 2003-05-09 11:00 UTC (permalink / raw)
To: Andrey Petrov; +Cc: binutils
On Thu, May 08, 2003 at 08:10:28PM +0000, Andrey Petrov wrote:
> Index: elf.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/elf.c,v
> retrieving revision 1.182
> diff -u -p -r1.182 elf.c
> --- elf.c 24 Apr 2003 17:19:37 -0000 1.182
> +++ elf.c 8 May 2003 19:03:22 -0000
> @@ -2365,9 +2365,9 @@ elf_fake_sections (abfd, asect, failedpt
>
> this_hdr = &elf_section_data (asect)->this_hdr;
>
> - this_hdr->sh_name = (unsigned long) _bfd_elf_strtab_add (elf_shstrtab (abfd),
> + this_hdr->sh_name = (unsigned int) _bfd_elf_strtab_add (elf_shstrtab (abfd),
> asect->name, FALSE);
> - if (this_hdr->sh_name == (unsigned long) -1)
> + if (this_hdr->sh_name == (unsigned int) -1)
> {
> *failedptr = TRUE;
> return;
Applied. Thanks.
--
Alan Modra
IBM OzLabs - Linux Technology Centre
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-05-09 11:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-08 20:11 PATCH elf.c LP64 'comparsion is always false' Andrey Petrov
2003-05-09 11:00 ` Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).