public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] defaults options for s390*.
@ 2003-05-09 14:59 Martin Schwidefsky
  2003-05-09 15:03 ` Daniel Jacobowitz
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Schwidefsky @ 2003-05-09 14:59 UTC (permalink / raw)
  To: binutils

Hi,
one of the ld testcases fails because -m31 is used without -mesa. The s390
gas will not accept any instruction in this case because current_mode_mask
won't get its default value. This patch fixes it. Again, this applicable to
CVS head and the 2.14 branch as well. Ok to commit ?

blue skies,
  Martin.

2003-05-09  Martin Schwidefsky  <schwidefsky@de.ibm.com>

	* config/tc-s390.c (s390_target_format): Always call init_default_arch.

diff -urN src/gas/config/tc-s390.c src-s390/gas/config/tc-s390.c
--- src/gas/config/tc-s390.c	Fri May  9 16:11:57 2003
+++ src-s390/gas/config/tc-s390.c	Fri May  9 16:12:30 2003
@@ -351,8 +351,7 @@
 {
   /* We don't get a chance to initialize anything before we're called,
      so handle that now.  */
-  if (! s390_arch_size)
-    init_default_arch ();
+  init_default_arch ();
 
   return s390_arch_size == 64 ? "elf64-s390" : "elf32-s390";
 }

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] defaults options for s390*.
  2003-05-09 14:59 [PATCH] defaults options for s390* Martin Schwidefsky
@ 2003-05-09 15:03 ` Daniel Jacobowitz
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Jacobowitz @ 2003-05-09 15:03 UTC (permalink / raw)
  To: Martin Schwidefsky; +Cc: binutils

On Fri, May 09, 2003 at 04:58:10PM +0200, Martin Schwidefsky wrote:
> Hi,
> one of the ld testcases fails because -m31 is used without -mesa. The s390
> gas will not accept any instruction in this case because current_mode_mask
> won't get its default value. This patch fixes it. Again, this applicable to
> CVS head and the 2.14 branch as well. Ok to commit ?

OK for the branch when it goes in to head; I don't know whose approval
you're waiting for :)


> 
> blue skies,
>   Martin.
> 
> 2003-05-09  Martin Schwidefsky  <schwidefsky@de.ibm.com>
> 
> 	* config/tc-s390.c (s390_target_format): Always call init_default_arch.
> 
> diff -urN src/gas/config/tc-s390.c src-s390/gas/config/tc-s390.c
> --- src/gas/config/tc-s390.c	Fri May  9 16:11:57 2003
> +++ src-s390/gas/config/tc-s390.c	Fri May  9 16:12:30 2003
> @@ -351,8 +351,7 @@
>  {
>    /* We don't get a chance to initialize anything before we're called,
>       so handle that now.  */
> -  if (! s390_arch_size)
> -    init_default_arch ();
> +  init_default_arch ();
>  
>    return s390_arch_size == 64 ? "elf64-s390" : "elf32-s390";
>  }
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] defaults options for s390*.
@ 2003-05-09 15:08 Martin Schwidefsky
  0 siblings, 0 replies; 3+ messages in thread
From: Martin Schwidefsky @ 2003-05-09 15:08 UTC (permalink / raw)
  To: Daniel Jacobowitz; +Cc: binutils


> OK for the branch when it goes in to head; I don't know whose approval
> you're waiting for :)

Oh, well branch are always more touchy then the head. Just to make sure...

blue skies,
   Martin


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-05-09 15:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-09 14:59 [PATCH] defaults options for s390* Martin Schwidefsky
2003-05-09 15:03 ` Daniel Jacobowitz
2003-05-09 15:08 Martin Schwidefsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).