From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15923 invoked by alias); 14 May 2003 23:52:25 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 15726 invoked from network); 14 May 2003 23:52:21 -0000 Received: from unknown (HELO iris1.csv.ica.uni-stuttgart.de) (129.69.118.2) by sources.redhat.com with SMTP; 14 May 2003 23:52:21 -0000 Received: from rembrandt.csv.ica.uni-stuttgart.de ([129.69.118.42]) by iris1.csv.ica.uni-stuttgart.de with esmtp (Exim 3.36 #2) id 19G62k-001FkU-00 for binutils@sources.redhat.com; Thu, 15 May 2003 01:52:18 +0200 Received: from ica2_ts by rembrandt.csv.ica.uni-stuttgart.de with local (Exim 3.35 #1 (Debian)) id 19G62k-0006e3-00 for ; Thu, 15 May 2003 01:52:18 +0200 Date: Wed, 14 May 2003 23:52:00 -0000 To: binutils@sources.redhat.com Subject: [PATCH] MIPS gas: Use PIC_CALL_REG instead of uninitialized tempreg Message-ID: <20030514235218.GI8833@rembrandt.csv.ica.uni-stuttgart.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4i From: Thiemo Seufer X-SW-Source: 2003-05/txt/msg00439.txt.bz2 Hello All, tempreg isn't properly initialized in this case and should AFAICS always be PIC_CALL_REG anyway. Thiemo 2003-05-15 Thiemo Seufer /gas/ChangeLog * config/tc-mips.c (macro): Don't use uninitialized tempreg. --- source-orig/gas/config/tc-mips.c Wed May 7 11:17:46 2003 +++ source/gas/config/tc-mips.c Wed May 14 05:27:09 2003 @@ -5831,11 +5841,11 @@ macro (ip) offset_expr.X_add_symbol, 0, NULL); macro_build (p, &icnt, &offset_expr, HAVE_32BIT_ADDRESSES ? "lw" : "ld", "t,o(b)", - tempreg, (int) BFD_RELOC_MIPS_GOT_PAGE, + PIC_CALL_REG, (int) BFD_RELOC_MIPS_GOT_PAGE, mips_gp_register); macro_build (p + 4, &icnt, &offset_expr, HAVE_32BIT_ADDRESSES ? "addi" : "daddiu", - "t,r,j", tempreg, tempreg, + "t,r,j", PIC_CALL_REG, PIC_CALL_REG, (int) BFD_RELOC_MIPS_GOT_OFST); }