From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-26227-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 13099 invoked by alias); 15 May 2003 02:02:02 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 12968 invoked from network); 15 May 2003 02:01:58 -0000
Received: from unknown (HELO iris1.csv.ica.uni-stuttgart.de) (129.69.118.2)
  by sources.redhat.com with SMTP; 15 May 2003 02:01:58 -0000
Received: from rembrandt.csv.ica.uni-stuttgart.de ([129.69.118.42])
	by iris1.csv.ica.uni-stuttgart.de with esmtp (Exim 3.36 #2)
	id 19G84C-001EoH-00
	for binutils@sources.redhat.com; Thu, 15 May 2003 04:01:56 +0200
Received: from ica2_ts by rembrandt.csv.ica.uni-stuttgart.de with local (Exim 3.35 #1 (Debian))
	id 19G84B-0003lI-00
	for <binutils@sources.redhat.com>; Thu, 15 May 2003 04:01:55 +0200
Date: Thu, 15 May 2003 02:02:00 -0000
To: binutils@sources.redhat.com
Subject: Re: [PATCH] MIPS gas: Use PIC_CALL_REG instead of uninitialized tempreg
Message-ID: <20030515020154.GN8833@rembrandt.csv.ica.uni-stuttgart.de>
References: <20030514235218.GI8833@rembrandt.csv.ica.uni-stuttgart.de> <20030515005505.GM8833@rembrandt.csv.ica.uni-stuttgart.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030515005505.GM8833@rembrandt.csv.ica.uni-stuttgart.de>
User-Agent: Mutt/1.4i
From: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
X-SW-Source: 2003-05/txt/msg00451.txt.bz2

Thiemo Seufer wrote:
[snip]
> > 2003-05-15  Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
> > 
> > 	/gas/ChangeLog
> > 	* config/tc-mips.c (macro): Don't use uninitialized tempreg.
> 
> This was tested on mips64-linux and mips-sgi-irix6, both without
> new regressions.
> 
> I guess it built/passed the testsuite before because the M_JAL_A
> case where the code lives in isn't triggered by ususal compiler
> generated code.

This adds a testcase which fails for the old code.


Thiemo


2003-05-15  Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>

	/gas/testsuite/ChangeLog
	* gas/mips/jal-newabi.s: New file, testcase for NewABI xgot jal macro.
	* gas/mips/jal-newabi.d: Likewise.
	* gas/mips/mips.exp: Add new testcase.


diff -BurpNX /bigdisk/src/gcc-exclude source-orig/gas/testsuite/gas/mips/jal-newabi.d source/gas/testsuite/gas/mips/jal-newabi.d
--- source-orig/gas/testsuite/gas/mips/jal-newabi.d	Thu Jan  1 01:00:00 1970
+++ source/gas/testsuite/gas/mips/jal-newabi.d	Thu May 15 03:49:43 2003
@@ -0,0 +1,17 @@
+#objdump: -dr --prefix-addresses --show-raw-insn
+#name: MIPS ELF NewABI jal
+#as: -n32 -KPIC -xgot
+
+.*: +file format elf32-n.*mips.*
+
+Disassembly of section \.text:
+00000000 <label> 3c041234 	lui	a0,0x1234
+00000004 <label\+0x4> 34845678 	ori	a0,a0,0x5678
+00000008 <label\+0x8> 8f990000 	lw	t9,0\(gp\)
+			8: R_MIPS_GOT_PAGE	.text
+0000000c <label\+0xc> 23390000 	addi	t9,t9,0
+			c: R_MIPS_GOT_OFST	.text
+00000010 <label\+0x10> 0320f809 	jalr	t9
+			10: R_MIPS_JALR	.text
+00000014 <label\+0x14> 00000000 	nop
+	...
diff -BurpNX /bigdisk/src/gcc-exclude source-orig/gas/testsuite/gas/mips/jal-newabi.s source/gas/testsuite/gas/mips/jal-newabi.s
--- source-orig/gas/testsuite/gas/mips/jal-newabi.s	Thu Jan  1 01:00:00 1970
+++ source/gas/testsuite/gas/mips/jal-newabi.s	Thu May 15 03:18:03 2003
@@ -0,0 +1,7 @@
+# Source file used to test the jal macro for NewABI.
+label:
+	dli $4, 0x12345678
+	jal label
+
+# Make objdump print ...
+	.space 8
diff -BurpNX /bigdisk/src/gcc-exclude source-orig/gas/testsuite/gas/mips/mips.exp source/gas/testsuite/gas/mips/mips.exp
--- source-orig/gas/testsuite/gas/mips/mips.exp	Wed May  7 11:17:51 2003
+++ source/gas/testsuite/gas/mips/mips.exp	Thu May 15 03:07:06 2003
@@ -448,6 +448,7 @@ if { [istarget mips*-*-*] } then {
 	run_dump_test_arches "jal-empic-elf-3" [mips_arch_list_matching mips1]
     }
     run_list_test_arches "jal-range" "-32" [mips_arch_list_matching mips1]
+    if $has_newabi { run_dump_test "jal-newabi" }
     if !$aout { run_dump_test "la" }
     if $elf { run_dump_test "la-svr4pic" }
     if $elf { run_dump_test "la-xgot" }