From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1399 invoked by alias); 23 May 2003 15:06:56 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 1367 invoked from network); 23 May 2003 15:06:55 -0000 Received: from unknown (HELO crack.them.org) (146.82.138.56) by sources.redhat.com with SMTP; 23 May 2003 15:06:55 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 19JE8i-0004HR-00; Fri, 23 May 2003 10:07:24 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19JE88-0000EQ-00; Fri, 23 May 2003 11:06:48 -0400 Date: Fri, 23 May 2003 15:06:00 -0000 From: Daniel Jacobowitz To: Eric Christopher Cc: Thiemo Seufer , binutils@sources.redhat.com Subject: Re: [PATCH] MIPS gas: Use PIC_CALL_REG instead of uninitialized tempreg Message-ID: <20030523150648.GB841@nevyn.them.org> Mail-Followup-To: Eric Christopher , Thiemo Seufer , binutils@sources.redhat.com References: <20030514235218.GI8833@rembrandt.csv.ica.uni-stuttgart.de> <1053551496.26893.13.camel@ghostwheel.sfbay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1053551496.26893.13.camel@ghostwheel.sfbay.redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-05/txt/msg00712.txt.bz2 On Wed, May 21, 2003 at 02:11:36PM -0700, Eric Christopher wrote: > > > tempreg isn't properly initialized in this case and should AFAICS > > always be PIC_CALL_REG anyway. > > > > agreed. > > > > > Thiemo > > > > > > 2003-05-15 Thiemo Seufer > > > > /gas/ChangeLog > > * config/tc-mips.c (macro): Don't use uninitialized tempreg. > > > > Please apply to mainline. > > Daniel: this is needed on the branch. Thanks. Please ack for Thiemo to > apply to branch. Sure, thank you both. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer