From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13519 invoked by alias); 27 May 2003 12:34:20 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 13449 invoked from network); 27 May 2003 12:34:19 -0000 Received: from unknown (HELO mta01ps.bigpond.com) (144.135.25.133) by sources.redhat.com with SMTP; 27 May 2003 12:34:19 -0000 Received: from bubble.local ([144.135.25.81]) by mta01ps.bigpond.com (Netscape Messaging Server 4.15 mta01ps Jul 16 2002 22:47:55) with SMTP id HFJPL400.5LD for ; Tue, 27 May 2003 22:34:16 +1000 Received: from CPE-144-136-188-60.sa.bigpond.net.au ([144.136.188.60]) by psmam05bpa.bigpond.com(MailRouter V3.2g 107/642974); 27 May 2003 22:34:16 Received: (qmail 15735 invoked by uid 179); 27 May 2003 12:34:16 -0000 From: amodra@bigpond.net.au Date: Tue, 27 May 2003 12:34:00 -0000 To: Michal Ludvig Cc: binutils@sources.redhat.com Subject: Re: [RFA] CFI improvements Message-ID: <20030527123416.GB15725@bubble.sa.bigpond.net.au> Mail-Followup-To: Michal Ludvig , binutils@sources.redhat.com References: <3ECBACDE.5030104@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3ECBACDE.5030104@suse.cz> User-Agent: Mutt/1.4i X-SW-Source: 2003-05/txt/msg00782.txt.bz2 On Wed, May 21, 2003 at 06:44:14PM +0200, Michal Ludvig wrote: > + if ((value = tc_regname_to_dw2regnum (input_line_pointer, &size)) >= 0) > + { Here and other places you indent braces incorrectly. Please fix. > - regnames_count = sizeof (regnames_64); > + regnames_count = sizeof (regnames_64) / sizeof (void*); Better to divide by sizeof (regnames_64[0]), then it's obvious in just this one line of code that you're calculating an array size. > - regnames_count = sizeof (regnames_32); > + regnames_count = sizeof (regnames_32) / sizeof (void*); Same thing here. > + while ((*p >= 'a' && *p <= 'z') > + || (*p >= 'A' && *p <= 'Z') > + || (*p >= '0' && *p <= '9')) while (ISALNUM (*p)) > + /* Save char at *p only when it isn't \0. */ Why not save it when it is 0 too? Saves a test, here and later when you restore. -- Alan Modra IBM OzLabs - Linux Technology Centre