From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13850 invoked by alias); 17 Jul 2003 13:22:47 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 13842 invoked from network); 17 Jul 2003 13:22:45 -0000 Received: from unknown (HELO mta03bw.bigpond.com) (139.134.6.86) by sources.redhat.com with SMTP; 17 Jul 2003 13:22:45 -0000 Received: from bubble.local ([144.135.24.78]) by mta03bw.bigpond.com (Netscape Messaging Server 4.15 mta03bw Jul 16 2002 22:47:55) with SMTP id HI67TV00.4RU for ; Thu, 17 Jul 2003 23:22:43 +1000 Received: from cpe-144-136-188-60.sa.bigpond.net.au ([144.136.188.60]) by bwmam04bpa.bigpond.com(MAM REL_3_3_2c 35/5954473); 17 Jul 2003 23:25:26 Received: (qmail 21586 invoked by uid 179); 17 Jul 2003 13:22:42 -0000 Date: Thu, 17 Jul 2003 13:22:00 -0000 From: Alan Modra To: Richard Henderson Cc: binutils@gcc.gnu.org Subject: Re: [RFC] unify dynamic_symbol_p implementations Message-ID: <20030717132242.GX27145@bubble.sa.bigpond.net.au> Mail-Followup-To: Richard Henderson , binutils@gcc.gnu.org References: <20030716164750.A8117@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030716164750.A8117@redhat.com> User-Agent: Mutt/1.4i X-SW-Source: 2003-07/txt/msg00315.txt.bz2 On Wed, Jul 16, 2003 at 04:47:50PM -0700, Richard Henderson wrote: > * elflink.c (_bfd_elf_dynamic_symbol_p): New. > * elf-bfd.h (_bfd_elf_dynamic_symbol_p): Declare it. > (SYMBOL_REFERENCES_LOCAL, SYMBOL_CALLS_LOCAL): Use it. Looks reasonable to me, except these hunks. > @@ -3952,7 +3927,7 @@ elfNN_ia64_relocate_section (output_bfd, > /* If we don't need dynamic symbol lookup, find a > matching RELATIVE relocation. */ > dyn_r_type = r_type; > - if (! local_symbol_p) > + if (! dynamic_symbol_p) > { > dynindx = h->dynindx; > addend = rel->r_addend; > @@ -4300,7 +4275,7 @@ elfNN_ia64_relocate_section (output_bfd, > > /* If we don't need dynamic symbol lookup, install two > RELATIVE relocations. */ > - if (local_symbol_p) > + if (dynamic_symbol_p) > { > unsigned int dyn_r_type; > -- Alan Modra IBM OzLabs - Linux Technology Centre