From: "H. J. Lu" <hjl@lucon.org>
To: Richard Henderson <rth@redhat.com>
Cc: binutils@gcc.gnu.org
Subject: Re: [RFC] unify dynamic_symbol_p implementations
Date: Thu, 17 Jul 2003 19:28:00 -0000 [thread overview]
Message-ID: <20030717192830.GA392@lucon.org> (raw)
In-Reply-To: <20030717162815.GC10459@redhat.com>
On Thu, Jul 17, 2003 at 09:28:15AM -0700, Richard Henderson wrote:
> On Thu, Jul 17, 2003 at 10:52:42PM +0930, Alan Modra wrote:
> > Looks reasonable to me, except these hunks.
>
> Um, those hunks are exactly the unification of the
> STV_PROTECTED handling vs function descriptors.
>
You changed
dynamic_symbol_p = elfNN_ia64_dynamic_symbol_p (h, info);
local_symbol_p = (! dynamic_symbol_p
|| ELF_ST_VISIBILITY (h->other) != STV_DEFAULT);
...
if (! local_symbol_p)
...
if (local_symbol_p)
...
to
dynamic_symbol_p = elfNN_ia64_dynamic_symbol_p (h, info, r_type);
...
if (! dynamic_symbol_p)
...
if (dynamic_symbol_p)
...
For those symbols on which the new elfNN_ia64_dynamic_symbol_p returns
the same as the old one, the code logic is reversed. Is that
intentional?
H.J.
next prev parent reply other threads:[~2003-07-17 19:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-16 23:47 Richard Henderson
2003-07-17 13:22 ` Alan Modra
2003-07-17 16:28 ` Richard Henderson
2003-07-17 19:28 ` H. J. Lu [this message]
2003-07-17 21:18 ` Hans-Peter Nilsson
2003-07-18 21:05 ` Richard Henderson
2003-07-18 19:02 Bob Wilson
2003-07-18 19:57 ` Richard Henderson
2003-07-18 20:09 ` Bob Wilson
2003-07-18 20:56 ` Richard Henderson
2003-07-18 21:19 ` Bob Wilson
2003-07-18 22:02 ` Richard Henderson
2003-07-18 22:06 ` Daniel Jacobowitz
2003-07-18 22:16 ` Bob Wilson
2003-07-18 22:21 ` Richard Henderson
2003-07-19 2:46 ` H. J. Lu
2003-07-19 4:13 ` H. J. Lu
2003-07-19 4:48 ` H. J. Lu
2003-07-19 5:57 ` Alan Modra
2003-07-19 6:21 ` H. J. Lu
2003-07-20 15:13 ` Alan Modra
2003-07-20 15:26 ` H. J. Lu
2003-07-21 0:24 ` Alan Modra
2003-07-21 3:18 ` H. J. Lu
2003-07-21 19:28 ` H. J. Lu
2003-07-21 20:48 ` Richard Henderson
2003-07-21 21:04 ` H. J. Lu
2003-07-21 23:26 ` Ulrich Drepper
2003-07-22 1:18 ` Alan Modra
2003-07-22 3:37 ` Ulrich Drepper
2003-07-24 0:23 ` Bob Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030717192830.GA392@lucon.org \
--to=hjl@lucon.org \
--cc=binutils@gcc.gnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).