From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-27874-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 17302 invoked by alias); 17 Jul 2003 19:28:31 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 17278 invoked from network); 17 Jul 2003 19:28:31 -0000
Received: from unknown (HELO sccrmhc12.comcast.net) (204.127.202.56)
  by sources.redhat.com with SMTP; 17 Jul 2003 19:28:31 -0000
Received: from lucon.org ([12.234.88.5]) by comcast.net (sccrmhc12) with ESMTP
          id <2003071719283001200e20ope>; Thu, 17 Jul 2003 19:28:30 +0000
Received: by lucon.org (Postfix, from userid 1000)
	id 21F622C4EB; Thu, 17 Jul 2003 19:28:30 +0000 (UTC)
Date: Thu, 17 Jul 2003 19:28:00 -0000
From: "H. J. Lu" <hjl@lucon.org>
To: Richard Henderson <rth@redhat.com>
Cc: binutils@gcc.gnu.org
Subject: Re: [RFC] unify dynamic_symbol_p implementations
Message-ID: <20030717192830.GA392@lucon.org>
References: <20030716164750.A8117@redhat.com> <20030717132242.GX27145@bubble.sa.bigpond.net.au> <20030717162815.GC10459@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030717162815.GC10459@redhat.com>
User-Agent: Mutt/1.4.1i
X-SW-Source: 2003-07/txt/msg00332.txt.bz2

On Thu, Jul 17, 2003 at 09:28:15AM -0700, Richard Henderson wrote:
> On Thu, Jul 17, 2003 at 10:52:42PM +0930, Alan Modra wrote:
> > Looks reasonable to me, except these hunks.
> 
> Um, those hunks are exactly the unification of the 
> STV_PROTECTED handling vs function descriptors.
> 

You changed

  dynamic_symbol_p = elfNN_ia64_dynamic_symbol_p (h, info);
  local_symbol_p = (! dynamic_symbol_p
		    || ELF_ST_VISIBILITY (h->other) != STV_DEFAULT);
  ...
  if (! local_symbol_p)
  ...
  if (local_symbol_p)
  ...

to

  dynamic_symbol_p = elfNN_ia64_dynamic_symbol_p (h, info, r_type);
  ...
  if (! dynamic_symbol_p)
  ...
  if (dynamic_symbol_p)
  ...

For those symbols on which the new elfNN_ia64_dynamic_symbol_p returns
the same as the old one, the code logic is reversed. Is that
intentional?


H.J.