From: Alan Modra <amodra@bigpond.net.au>
To: "H. J. Lu" <hjl@lucon.org>
Cc: Nick Clifton <nickc@redhat.com>, binutils@sources.redhat.com
Subject: Re: PATCH: Don't use section name to set ELF section data
Date: Fri, 25 Jul 2003 04:48:00 -0000 [thread overview]
Message-ID: <20030725044515.GK27145@bubble.sa.bigpond.net.au> (raw)
In-Reply-To: <20030725013603.GB17609@lucon.org>
On Thu, Jul 24, 2003 at 06:36:03PM -0700, H. J. Lu wrote:
> * config/obj-elf.h (obj_sec_set_private_data): New.
>
> * subsegs.c (subseg_get): Call obj_sec_set_private_data if it
> is defined.
This is presumably to tack bfd_elf_section_data onto the standard abs,
com, und and ind sections. Howver, some targets allocate a larger
structure. You should be going via bfd_target._new_section_hook. ie.
BFD_SEND (stdoutput, _new_section_hook, (stdoutput, secptr))
This will also fix a possible problem with multi-obj gas support, where
obj-elf.h is included but you might be producing COFF output.
Also, I think the initialization should be done elsewhere, probably
gas/output-file.c:output_file_create.
--
Alan Modra
IBM OzLabs - Linux Technology Centre
next prev parent reply other threads:[~2003-07-25 4:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-14 19:14 RFC: " H. J. Lu
2003-06-19 19:17 ` Andreas Schwab
[not found] ` <m3y901rluw.fsf@redhat.com>
2003-07-25 1:36 ` PATCH: " H. J. Lu
2003-07-25 4:48 ` Alan Modra [this message]
2003-07-25 14:39 ` H. J. Lu
2003-07-25 12:29 ` Nick Clifton
2003-07-25 14:38 ` H. J. Lu
2003-07-25 16:10 ` H. J. Lu
2003-07-25 17:43 ` H. J. Lu
2003-07-25 17:59 ` H. J. Lu
2003-07-26 0:09 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030725044515.GK27145@bubble.sa.bigpond.net.au \
--to=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
--cc=hjl@lucon.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).