From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20634 invoked by alias); 25 Jul 2003 04:48:17 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 20627 invoked from network); 25 Jul 2003 04:48:16 -0000 Received: from unknown (HELO mta07ps.bigpond.com) (144.135.25.132) by sources.redhat.com with SMTP; 25 Jul 2003 04:48:16 -0000 Received: from bubble.local ([144.135.25.75]) by mta07ps.email.bigpond.com (iPlanet Messaging Server 5.2 HotFix 1.14 (built Mar 18 2003)) with SMTP id <0HIK00KJGD7GMU@mta07ps.email.bigpond.com> for binutils@sources.redhat.com; Fri, 25 Jul 2003 14:45:16 +1000 (EST) Received: from cpe-144-136-188-60.sa.bigpond.net.au ([144.136.188.60]) by psmam03bpa.bigpond.com(MAM REL_3_3_2c 89/10476714); Fri, 25 Jul 2003 14:45:15 +0000 Received: (qmail 8265 invoked by uid 179); Fri, 25 Jul 2003 04:45:15 +0000 Date: Fri, 25 Jul 2003 04:48:00 -0000 From: Alan Modra Subject: Re: PATCH: Don't use section name to set ELF section data In-reply-to: <20030725013603.GB17609@lucon.org> To: "H. J. Lu" Cc: Nick Clifton , binutils@sources.redhat.com Mail-followup-to: "H. J. Lu" , Nick Clifton , binutils@sources.redhat.com Message-id: <20030725044515.GK27145@bubble.sa.bigpond.net.au> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT Content-disposition: inline User-Agent: Mutt/1.4i References: <20030614190932.GA5459@lucon.org> <20030725013603.GB17609@lucon.org> X-SW-Source: 2003-07/txt/msg00502.txt.bz2 On Thu, Jul 24, 2003 at 06:36:03PM -0700, H. J. Lu wrote: > * config/obj-elf.h (obj_sec_set_private_data): New. > > * subsegs.c (subseg_get): Call obj_sec_set_private_data if it > is defined. This is presumably to tack bfd_elf_section_data onto the standard abs, com, und and ind sections. Howver, some targets allocate a larger structure. You should be going via bfd_target._new_section_hook. ie. BFD_SEND (stdoutput, _new_section_hook, (stdoutput, secptr)) This will also fix a possible problem with multi-obj gas support, where obj-elf.h is included but you might be producing COFF output. Also, I think the initialization should be done elsewhere, probably gas/output-file.c:output_file_create. -- Alan Modra IBM OzLabs - Linux Technology Centre