Re: PATCH: Don't use section name to set ELF section data

["H. J. Lu" <hjl@lucon.org>]

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

On Fri, Jul 25, 2003 at 07:38:06AM -0700, H. J. Lu wrote:
> On Fri, Jul 25, 2003 at 01:25:31PM +0100, Nick Clifton wrote:
> > Hi H.J.
> > 
> > > Here is the new patch. It caused no regressions on all targets
> > > affected. It fixed an ELF/ppc64 bug.
> > 
> > Excellent.
> 
> ...
> 
> > Approved - please apply.
> > 
> 
> Done. I made a small change. I used
> 
>   if (! BFD_SEND ((B), _new_section_hook, ((B), (S)))) \
> 
> instead of
> 
>   if (!_bfd_elf_new_section_hook ((B), (S)))                  \
>  

My patch mishandled the case:

	.section .foo,"aw",@nobits

I checked in the following patch as an obvious fix.


H.J.

[-- Attachment #2: gas-type.patch --]
[-- Type: text/plain, Size: 641 bytes --]

2003-07-25  H.J. Lu  <hongjiu.lu@intel.com>

	* config/obj-elf.c (obj_elf_change_section): Always set section
	type and flags.

--- gas/config/obj-elf.c.type	2003-07-25 09:03:06.000000000 -0700
+++ gas/config/obj-elf.c	2003-07-25 08:59:49.000000000 -0700
@@ -681,11 +681,11 @@ obj_elf_change_section (name, type, attr
 		     name);
 	}
       attr |= def_attr;
-
-      elf_section_type (sec) = type;
-      elf_section_flags (sec) = attr;
     }
 
+  elf_section_type (sec) = type;
+  elf_section_flags (sec) = attr;
+
   /* Convert ELF type and flags to BFD flags.  */
   flags = (SEC_RELOC
 	   | ((attr & SHF_WRITE) ? 0 : SEC_READONLY)