From: Jakub Jelinek <jakub@redhat.com>
To: binutils@sources.redhat.com, "H.J. Lu" <hongjiu.lu@intel.com>
Subject: Re: got and plt section attributes
Date: Mon, 28 Jul 2003 14:42:00 -0000 [thread overview]
Message-ID: <20030728144245.GP20507@sunsite.ms.mff.cuni.cz> (raw)
In-Reply-To: <20030728142440.GY27145@bubble.sa.bigpond.net.au>
On Mon, Jul 28, 2003 at 11:54:40PM +0930, Alan Modra wrote:
> This fixes warnings about "setting incorrect section attributes for
> .got" when compiling gcc/config/rs6000/eabi-ci.asm.
>
> * elf.c (special_sections): Set attributes for .got and .plt.
>
> Index: bfd/elf.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/elf.c,v
> retrieving revision 1.193
> diff -u -p -r1.193 elf.c
> --- bfd/elf.c 26 Jul 2003 01:06:27 -0000 1.193
> +++ bfd/elf.c 28 Jul 2003 14:10:11 -0000
> @@ -2192,13 +2192,13 @@ static struct bfd_elf_special_section co
> { ".dynsym", 0, NULL, 0,
> SHT_DYNSYM, SHF_ALLOC },
> { ".got", 0, NULL, 0,
> - SHT_PROGBITS, 0 },
> + SHT_PROGBITS, SHF_ALLOC + SHF_WRITE },
> { ".hash", 0, NULL, 0,
> SHT_HASH, SHF_ALLOC },
> { ".interp", 0, NULL, 0,
> SHT_PROGBITS, 0 },
> { ".plt", 0, NULL, 0,
> - SHT_PROGBITS, 0 },
> + SHT_PROGBITS, SHF_ALLOC + SHF_EXECINSTR },
.plt is SHF_ALLOC + SHF_WRITE + SHF_EXECINSTR on about half of ELF arches I
think (and SHT_NOBITS on ppc/ppc64).
Do we really expect half of the arches to define their own special_section
table with .plt section, or shouldn't backends inform ELF generic code
whether they use .got.plt or not?
Jakub
next prev parent reply other threads:[~2003-07-28 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-28 14:24 Alan Modra
2003-07-28 14:42 ` Jakub Jelinek [this message]
2003-07-28 15:01 ` Alan Modra
2003-07-28 14:32 Lu, Hongjiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030728144245.GP20507@sunsite.ms.mff.cuni.cz \
--to=jakub@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=hongjiu.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).