From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-28293-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 5892 invoked by alias); 7 Aug 2003 01:18:16 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 5884 invoked from network); 7 Aug 2003 01:18:16 -0000
Received: from unknown (HELO redhat.com) (24.131.133.249)
  by sources.redhat.com with SMTP; 7 Aug 2003 01:18:16 -0000
Received: by redhat.com (Postfix, from userid 201)
	id 1C13132A78E; Wed,  6 Aug 2003 21:18:16 -0400 (EDT)
Date: Thu, 07 Aug 2003 01:18:00 -0000
From: Christopher Faylor <cgf@redhat.com>
To: Danny Smith <danny_r_smith_2001@yahoo.co.nz>
Cc: binutils <binutils@sources.redhat.com>
Subject: Re: [Patch]  pe-i386: Fix --subsystem windows option
Message-ID: <20030807011816.GA27109@redhat.com>
Mail-Followup-To: Danny Smith <danny_r_smith_2001@yahoo.co.nz>,
	binutils <binutils@sources.redhat.com>
References: <20030807003811.83459.qmail@web21414.mail.yahoo.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030807003811.83459.qmail@web21414.mail.yahoo.com>
User-Agent: Mutt/1.4.1i
X-SW-Source: 2003-08/txt/msg00101.txt.bz2

On Thu, Aug 07, 2003 at 10:38:11AM +1000, Danny Smith wrote:
>2003-08-07  Danny Smith  <dannysmith@users.sourceforge.net>
>
>	* emultempl/pe.em (gld_${EMULATION_NAME}_before_parse):
>	Change second (cmdline) arg to lang_add_entry to FALSE.
>	(set_pe_subsystem): Change second arg to lang_add_entry to TRUE.

Looks right.  It seems like this has been broken for a long time.
Hard to believe.

Ok to apply.

cgf

>Index: emultempl/pe.em
>===================================================================
>RCS file: /cvs/src/src/ld/emultempl/pe.em,v
>retrieving revision 1.80
>diff -c -3 -p -r1.80 pe.em
>*** emultempl/pe.em	27 Jun 2003 00:38:25 -0000	1.80
>--- emultempl/pe.em	6 Aug 2003 23:53:08 -0000
>*************** gld_${EMULATION_NAME}_before_parse (void
>*** 141,149 ****
>  
>  #if (PE_DEF_SUBSYSTEM == 9) || (PE_DEF_SUBSYSTEM == 2)
>  #if defined TARGET_IS_mipspe || defined TARGET_IS_armpe
>!   lang_add_entry ("WinMainCRTStartup", 1);
>  #else
>!   lang_add_entry ("_WinMainCRTStartup", 1);
>  #endif
>  #endif
>  #endif
>--- 141,149 ----
>  
>  #if (PE_DEF_SUBSYSTEM == 9) || (PE_DEF_SUBSYSTEM == 2)
>  #if defined TARGET_IS_mipspe || defined TARGET_IS_armpe
>!   lang_add_entry ("WinMainCRTStartup", FALSE);
>  #else
>!   lang_add_entry ("_WinMainCRTStartup", FALSE);
>  #endif
>  #endif
>  #endif
>*************** set_pe_subsystem (void)
>*** 439,445 ****
>  	      entry = alc_entry;
>  	    }
>  
>! 	  lang_add_entry (entry, 0);
>  
>  	  return;
>  	}
>--- 439,445 ----
>  	      entry = alc_entry;
>  	    }
>  
>! 	  lang_add_entry (entry, TRUE);
>  
>  	  return;
>  	}
>
>http://personals.yahoo.com.au - Yahoo! Personals
>-  New people, new possibilities! Try Yahoo! Personals, FREE for a limited period!