public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Alan Modra <amodra@bigpond.net.au>
To: Richard Henderson <rth@redhat.com>
Cc: binutils@sources.redhat.com, mostrows@watson.ibm.com
Subject: Re: powerpc64-linux hack
Date: Tue, 12 Aug 2003 00:27:00 -0000	[thread overview]
Message-ID: <20030812002416.GB27145@bubble.sa.bigpond.net.au> (raw)
In-Reply-To: <20030811185734.GB24357@redhat.com>

On Mon, Aug 11, 2003 at 11:57:34AM -0700, Richard Henderson wrote:
> On Mon, Aug 11, 2003 at 08:59:52PM +0930, Alan Modra wrote:
> > +			   && strcmp (h->root.root.string,
> > +				      ".__libc_start_main") == 0)
> 
> You really should use a special branch relocation instead.
> This could be used elsewhere as well, no doubt.

Yeah, well, it didn't seem worth it.  The "right" fix in this instance
is to simply add a nop after the "bl .__libc_start_main" call in crt1.o.
It's not that the nop is needed as a placeholder to restore r2 because
we never return, but that the bl,nop sequence is used for extern calls
and is recognized by the linker.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

      reply	other threads:[~2003-08-12  0:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-11 11:29 Alan Modra
2003-08-11 18:11 ` Ulrich Drepper
2003-08-12  0:25   ` Alan Modra
2003-08-11 18:57 ` Richard Henderson
2003-08-12  0:27   ` Alan Modra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030812002416.GB27145@bubble.sa.bigpond.net.au \
    --to=amodra@bigpond.net.au \
    --cc=binutils@sources.redhat.com \
    --cc=mostrows@watson.ibm.com \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).