From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24069 invoked by alias); 30 Apr 2004 12:26:34 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 23919 invoked from network); 30 Apr 2004 12:26:33 -0000 Received: from unknown (HELO modra.org) (144.136.182.144) by sources.redhat.com with SMTP; 30 Apr 2004 12:26:33 -0000 Received: by bubble.modra.org (Postfix, from userid 500) id CD9AAE4C31; Fri, 30 Apr 2004 21:56:30 +0930 (CST) Date: Fri, 30 Apr 2004 12:28:00 -0000 From: Alan Modra To: "H. J. Lu" Cc: binutils@sources.redhat.com Subject: Re: PATCH: Handle section group for ld -r Message-ID: <20040430122630.GL2565@bubble.modra.org> Mail-Followup-To: "H. J. Lu" , binutils@sources.redhat.com References: <20040429205047.GA24657@lucon.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040429205047.GA24657@lucon.org> User-Agent: Mutt/1.4i X-SW-Source: 2004-04/txt/msg00800.txt.bz2 On Thu, Apr 29, 2004 at 01:50:47PM -0700, H. J. Lu wrote: > This patch fixes section group for ld -r. I doubt it. :) ld -r and sections groups are difficult to handle correctly. The problem is what to do with sections that have the same name as sections belonging to the group. Normally, ld -r would merge such sections, leading to other sections incorrectly becoming part of the group. We need to stop that happening, which could be done easily enough by modifying unique_section_p. I'll take a look at that. Meanwhile, I guess your patch is OK. > * elf.c (bfd_section_from_shdr): Maintain the section order in > a section group. > (special_sections): Add ".note.GNU-stack". > (elf_fake_sections): Handle section group for relocatable > link.. -- Alan Modra IBM OzLabs - Linux Technology Centre