PATCH: Use %3lu to display sh_info in readelf

PATCH: Use %3lu to display sh_info in readelf

[H. J. Lu]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

The sh_info field holds the section header index, which is displayed in
decimal. This patch changes sh_info to match it so that it is easier
to tell which section the sh_info field refers to.


H.J.

[-- Attachment #2: readelf-sh_info-1.patch --]
[-- Type: text/plain, Size: 1144 bytes --]

2004-04-29  H.J. Lu  <hongjiu.lu@intel.com>

	* readelf.c (process_section_headers): Use %3lu on sh_info.

--- binutils/readelf.c.sh_info	2004-04-26 21:12:42.000000000 -0700
+++ binutils/readelf.c	2004-04-29 17:05:16.000000000 -0700
@@ -3631,7 +3631,7 @@ process_section_headers (FILE *file)
 
 	  printf (" %3s ", get_elf_section_flags (section->sh_flags));
 
-	  printf ("%2ld %3lx %2ld\n",
+	  printf ("%2ld %3lu %2ld\n",
 		  (unsigned long) section->sh_link,
 		  (unsigned long) section->sh_info,
 		  (unsigned long) section->sh_addralign);
@@ -3666,7 +3666,7 @@ process_section_headers (FILE *file)
 
 	  printf (" %3s ", get_elf_section_flags (section->sh_flags));
 
-	  printf ("%2ld %3lx ",
+	  printf ("%2ld %3lu ",
 		  (unsigned long) section->sh_link,
 		  (unsigned long) section->sh_info);
 
@@ -3696,7 +3696,7 @@ process_section_headers (FILE *file)
 
 	  printf (" %3s ", get_elf_section_flags (section->sh_flags));
 
-	  printf ("     %2ld   %3lx     %ld\n",
+	  printf ("     %2ld   %3lu     %ld\n",
 		  (unsigned long) section->sh_link,
 		  (unsigned long) section->sh_info,
 		  (unsigned long) section->sh_addralign);

Re: PATCH: Use %3lu to display sh_info in readelf

[Nick Clifton]

Hi H. J.

>The sh_info field holds the section header index, which is displayed in
>decimal.
>
I assume that you mean "is displayed in some places as decimal and in 
others as hexadecimal" ?

> This patch changes sh_info to match it so that it is easier
>to tell which section the sh_info field refers to.
>  
>

This is approved - please apply.

Cheers
  Nick

Re: PATCH: Use %3lu to display sh_info in readelf

[Jakub Jelinek]

On Fri, Apr 30, 2004 at 08:33:10AM +0100, Nick Clifton wrote:
> Hi H. J.
> 
> >The sh_info field holds the section header index, which is displayed in
> >decimal.
> >
> I assume that you mean "is displayed in some places as decimal and in 
> others as hexadecimal" ?
> 
> >This patch changes sh_info to match it so that it is easier
> >to tell which section the sh_info field refers to.
> > 
> >
> 
> This is approved - please apply.

Don't we need to update big part of the testsuite for that change though?

	Jakub

Re: PATCH: Use %3lu to display sh_info in readelf

[H. J. Lu]

On Fri, Apr 30, 2004 at 07:36:26AM +0200, Jakub Jelinek wrote:
> On Fri, Apr 30, 2004 at 08:33:10AM +0100, Nick Clifton wrote:
> > Hi H. J.
> > 
> > >The sh_info field holds the section header index, which is displayed in
> > >decimal.
> > >
> > I assume that you mean "is displayed in some places as decimal and in 
> > others as hexadecimal" ?
> > 
> > >This patch changes sh_info to match it so that it is easier
> > >to tell which section the sh_info field refers to.
> > > 
> > >
> > 
> > This is approved - please apply.
> 
> Don't we need to update big part of the testsuite for that change though?
> 

Not on ia32 and ia64.


H.J.