gc-sections fix

gc-sections fix

[Alan Modra]

Now that we're doing gc-sections on apps linked with dynamic libs, we
need to be prepared to handle indirect syms.

bfd/ChangeLog
	* elflink.c (elf_gc_mark): Follow indirect and warning syms.

Index: bfd/elflink.c
===================================================================
RCS file: /cvs/src/src/bfd/elflink.c,v
retrieving revision 1.66
diff -u -p -r1.66 elflink.c
--- bfd/elflink.c	21 Apr 2004 07:14:15 -0000	1.66
+++ bfd/elflink.c	30 Apr 2004 08:39:08 -0000
@@ -8173,6 +8173,9 @@ elf_gc_mark (struct bfd_link_info *info,
 	      || ELF_ST_BIND (isym[r_symndx].st_info) != STB_LOCAL)
 	    {
 	      h = sym_hashes[r_symndx - extsymoff];
+	      while (h->root.type == bfd_link_hash_indirect
+		     || h->root.type == bfd_link_hash_warning)
+		h = (struct elf_link_hash_entry *) h->root.u.i.link;
 	      rsec = (*gc_mark_hook) (sec, info, rel, h, NULL);
 	    }
 	  else

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Re: gc-sections fix

[Eric Botcazou]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

> Now that we're doing gc-sections on apps linked with dynamic libs, we
> need to be prepared to handle indirect syms.

Ah!, yes :-)

It also occured to me that I didn't update the docs with my initial patch.

Ok for mainline?


ld/ChangeLog:

2004-04-30  Eric Botcazou <ebotcazou@act-europe.fr>

	* ld.texinfo (--gc-sections): Remove restriction for 
	dynamic linking.
	

-- 
Eric Botcazou

[-- Attachment #2: gc_sections_doc.diff --]
[-- Type: text/x-diff, Size: 852 bytes --]

Index: ld.texinfo
===================================================================
RCS file: /cvs/src/src/ld/ld.texinfo,v
retrieving revision 1.109
diff -u -r1.109 ld.texinfo
--- ld.texinfo	21 Apr 2004 06:08:47 -0000	1.109
+++ ld.texinfo	30 Apr 2004 10:37:51 -0000
@@ -1145,9 +1145,9 @@
 @itemx --gc-sections
 Enable garbage collection of unused input sections.  It is ignored on
 targets that do not support this option.  This option is not compatible
-with @samp{-r}, nor should it be used with dynamic linking.  The default
-behaviour (of not performing this garbage collection) can be restored by
-specifying @samp{--no-gc-sections} on the command line.
+with @samp{-r}. The default behaviour (of not performing this garbage
+collection) can be restored by specifying @samp{--no-gc-sections} on
+the command line.
 
 @cindex help
 @cindex usage

Re: gc-sections fix

[Alan Modra]

On Fri, Apr 30, 2004 at 12:47:58PM +0200, Eric Botcazou wrote:
> 	* ld.texinfo (--gc-sections): Remove restriction for 
> 	dynamic linking.

OK.  Incidentally, the --gc-sections problem showed up as a gcc
testsuite failure on powerpc64-linux, gcc.dg/special/gcsec-1.c.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Re: gc-sections fix

[Eric Botcazou]

> OK.  Incidentally, the --gc-sections problem showed up as a gcc
> testsuite failure on powerpc64-linux, gcc.dg/special/gcsec-1.c.

Thanks for fixing the regression.

-- 
Eric Botcazou