From: Alan Modra <amodra@bigpond.net.au>
To: Andrew Cagney <cagney@gnu.org>
Cc: binutils@sources.redhat.com
Subject: Re: [rfa] Add bfd-in-memory io vector
Date: Sun, 02 May 2004 13:56:00 -0000 [thread overview]
Message-ID: <20040502135641.GZ2565@bubble.modra.org> (raw)
In-Reply-To: <4093E817.9060704@gnu.org>
On Sat, May 01, 2004 at 02:10:31PM -0400, Andrew Cagney wrote:
> The testing comment still applies though.
Given DJ's comment, I think you should test this on cygwin before
committing. If you can't do this yourself, convince someone else
to do so for you. OK to commit once you've done this.
> --- opncls.c 23 Apr 2004 00:22:57 -0000 1.23
> +++ opncls.c 1 May 2004 18:01:00 -0000
[snip]
> + if ((abfd->direction == write_direction) ||
> + (abfd->direction == both_direction))
I know this was copied from the old code, but please fix the
formatting here and remove the unnecessary parentheses.
> + bim = ((struct bfd_in_memory *)
> + bfd_alloc (abfd, (bfd_size_type) sizeof (struct bfd_in_memory)));
Two unnecessary casts.
--
Alan Modra
IBM OzLabs - Linux Technology Centre
next prev parent reply other threads:[~2004-05-02 13:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-30 22:03 Andrew Cagney
2004-04-30 22:12 ` DJ Delorie
2004-04-30 23:01 ` Andrew Cagney
2004-05-01 18:10 ` Andrew Cagney
2004-05-02 13:56 ` Alan Modra [this message]
2004-05-03 17:19 ` Cygwin tester? Was: " Andrew Cagney
2004-05-03 22:46 ` Danny Smith
2004-05-04 10:00 ` Dave Korn
2004-05-04 17:39 ` Dave Korn
2004-05-08 1:13 ` Danny Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040502135641.GZ2565@bubble.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
--cc=cagney@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).