From: Peter Barada <peter@the-baradas.com>
To: nickc@redhat.com
Cc: binutils@sources.redhat.com
Subject: Re: Ping: [PATCH]: Support new ColdFire variants
Date: Wed, 05 May 2004 15:16:00 -0000 [thread overview]
Message-ID: <20040505151555.9006198C8A@baradas.org> (raw)
In-Reply-To: <4098FC17.7060907@redhat.com> (message from Nick Clifton on Wed, 05 May 2004 15:37:11 +0100)
>>Has anyone had a chance to look at my patch to add the new ColdFire
>>variants to binutils and clean up the current ColdFire instruction sets?
>>
>>
>Sorry - I have been swamped with other stuff.
>
>Anyway I have now had a chance to look over this patch and I am going to
>apply it with a few changes:
Thanks for looking it over.
> * Fix up the formatting in several places. (In particular you
>occasionally forgot to leave a space between a function name and the
>opening parenthesis of its arguments).
Guilty as charged :)
> * Fix up an apparent typo in the change to s_restore() in
>gas/config/tc-m68k.c:
>
>*************** s_save (ignore)
>*** 5709,5714 ****
>--- 5825,5831 ----
> s->keep_locals = flag_keep_locals;
> s->short_refs = flag_short_refs;
> s->architecture = current_architecture;
>+ s->architecture = current_chip;
> s->quick = m68k_quick;
> s->rel32 = m68k_rel32;
> s->listing = listing;
>
> I assumed that you meant to store the 'chip' global variable in the
>the 'chip' field of the save_opts structure.
Correct.
> * (most importantly): I ran the GAS testsuite with the patched
>toolchain - it generated lots of new failures. The cause was the
>function select_control_regs() which was now emitting the message
>"architecture not yet selected: defaulting to 68020" for lots of the
>tests. Since it was not clear to me whether this message was actually
>wrong (ie an ISA/chip had not been selected) I elected to change the
>code so that the message is only generated if the --verbose switch has
>been included on the command line. You may like to change this and
>arrange for 'current_chip' to be initialised by default.
I'll look at initializing current_chip and send in another patch.
--
Peter Barada
peter@the-baradas.com
next prev parent reply other threads:[~2004-05-05 15:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-23 19:06 Peter Barada
2004-04-30 21:50 ` Ping: " Peter Barada
2004-05-05 14:33 ` Nick Clifton
2004-05-05 15:16 ` Peter Barada [this message]
2004-06-20 19:33 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040505151555.9006198C8A@baradas.org \
--to=peter@the-baradas.com \
--cc=binutils@sources.redhat.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).