public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "John David Anglin" <dave@hiauly1.hia.nrc.ca>
To: amodra@bigpond.net.au (Alan Modra)
Cc: binutils@sources.redhat.com
Subject: Re: [parisc-linux] binutils 2.15?
Date: Mon, 05 Jul 2004 20:34:00 -0000	[thread overview]
Message-ID: <200407052034.i65KY0ke001308@hiauly1.hia.nrc.ca> (raw)
In-Reply-To: <20040702040316.GL21696@bubble.modra.org> from "Alan Modra" at Jul 2, 2004 01:33:16 pm

> That will be HJ's and my recent changes to elflink.c.  Likely fix is to
> add another strcmp to elf_section_complain_discarded.  That will be
> correct if your unwinder or whatever looks at .PARISC.unwind can cope
> with some zeros for entries corresponding to removed link-once sections.
> Otherwise the proper fix is to implement an
> elf_backend_ignore_discarded_relocs and elf_backend_discard_info that
> edits the unwind section.

Randolph Chung wrote:
> > Being the current expert on unwinding, do you know if we need more
> > than the simple fix?
> 
> As long as it keeps it sorted (with the zeroed entries at the beginning
> of the unwind section) it should be ok for gdb and the kernel unwinder.

I have tested the enclosed change with gcc builds on hppa-unknown-linux-gnu
(3.4 and 3.5) and hppa64-hp-hpux11.11 (3.5) and haven't noticed any
obvious regressions.  I have no idea how the hpux unwinder will handle
zeroed entries.  I assume GNU ld is sorting the entries as per Randolph's
comment.

Is this ok?

Dave
-- 
J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)

2004-07-05  John David Anglin  <dave.anglin@nrc-cnrc.gc.ca>

	* elflink.c (elf_section_complain_discarded): Don't complain about
	.PARISC.unwind.

Index: elflink.c
===================================================================
RCS file: /cvs/src/src/bfd/elflink.c,v
retrieving revision 1.79
diff -u -3 -p -r1.79 elflink.c
--- elflink.c	2 Jul 2004 01:39:31 -0000	1.79
+++ elflink.c	3 Jul 2004 17:51:49 -0000
@@ -6310,6 +6310,9 @@ elf_section_complain_discarded (asection
   if (strcmp (".gcc_except_table", sec->name) == 0)
     return FALSE;
 
+  if (strcmp (".PARISC.unwind", sec->name) == 0)
+    return FALSE;
+
   return TRUE;
 }
 

  parent reply	other threads:[~2004-07-05 20:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20040702040316.GL21696@bubble.modra.org>
2004-07-05 20:18 ` John David Anglin
2004-07-05 20:34 ` John David Anglin [this message]
     [not found] <40BDA020000074B9@ocpmta3.freegates.net>
2004-06-14  4:09 ` John David Anglin
2004-06-14  5:39   ` Jakub Jelinek
2004-06-14 12:08     ` Alan Modra
2004-06-21 15:18       ` Carlos O'Donell
2004-06-28  3:25         ` John David Anglin
2004-07-01 22:50       ` John David Anglin
2004-07-01 23:00         ` Jakub Jelinek
2004-07-22 10:09           ` Joel Soete

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200407052034.i65KY0ke001308@hiauly1.hia.nrc.ca \
    --to=dave@hiauly1.hia.nrc.ca \
    --cc=amodra@bigpond.net.au \
    --cc=binutils@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).