From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5438 invoked by alias); 12 Oct 2004 05:49:28 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 5429 invoked from network); 12 Oct 2004 05:49:27 -0000 Received: from unknown (HELO devserv.devel.redhat.com) (66.187.233.202) by sourceware.org with SMTP; 12 Oct 2004 05:49:27 -0000 Received: from devserv.devel.redhat.com (localhost.localdomain [127.0.0.1]) by devserv.devel.redhat.com (8.12.11/8.12.10) with ESMTP id i9C5n6UX026748 for ; Tue, 12 Oct 2004 01:49:06 -0400 Received: (from jakub@localhost) by devserv.devel.redhat.com (8.12.11/8.12.11/Submit) id i9C5n6cI026746 for binutils@sources.redhat.com; Tue, 12 Oct 2004 01:49:06 -0400 Date: Tue, 12 Oct 2004 05:49:00 -0000 From: Jakub Jelinek To: binutils@sources.redhat.com Subject: Re: [PATCH] Fix strings to work with > 2GB files again on 32-bit arches Message-ID: <20041012054906.GF31909@devserv.devel.redhat.com> Reply-To: Jakub Jelinek References: <20041011202028.GQ30497@sunsite.ms.mff.cuni.cz> <20041011231506.GE5641@bubble.modra.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041011231506.GE5641@bubble.modra.org> User-Agent: Mutt/1.4.1i X-SW-Source: 2004-10/txt/msg00179.txt.bz2 On Tue, Oct 12, 2004 at 08:45:06AM +0930, Alan Modra wrote: > On Mon, Oct 11, 2004 at 10:20:28PM +0200, Jakub Jelinek wrote: > > 2003-11-07 changes broke strings on arches with 32-bit off_t. > > The following patch fixes this, although I'm not sure if the > > What about all the other uses of get_file_size? Shouldn't you be fixing > get_file_size instead? All the other tools work with object files and handling there > 2GB files would require more changes than just get_file_size. strings works on all files and is ATM the only one using fopen64/etc. Plus I really think strings should work also on devices, which get_file_size refuses and it should work also on zero length files, which get_file_size doesn't like either. Jakub