public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* ld SORT_BY_* tests
@ 2004-10-11 11:03 Alan Modra
  2004-10-13 18:48 ` H. J. Lu
  0 siblings, 1 reply; 3+ messages in thread
From: Alan Modra @ 2004-10-11 11:03 UTC (permalink / raw)
  To: H.J. Lu; +Cc: binutils

Hi HJ,
  Practically all non-ELF targets are failing on the new tests.  Would
you please look into it?

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: ld SORT_BY_* tests
  2004-10-11 11:03 ld SORT_BY_* tests Alan Modra
@ 2004-10-13 18:48 ` H. J. Lu
  2004-10-14  8:53   ` Alan Modra
  0 siblings, 1 reply; 3+ messages in thread
From: H. J. Lu @ 2004-10-13 18:48 UTC (permalink / raw)
  To: binutils

On Mon, Oct 11, 2004 at 08:33:53PM +0930, Alan Modra wrote:
> Hi HJ,
>   Practically all non-ELF targets are failing on the new tests.  Would
> you please look into it?
> 

I don't have good solutions except for creating another set of expected
outputs for each format which is different from ELF. Since this feature
is format independent and ELF is the most widely used target, testing
it on ELF should be sufficient.


H.J.
----
2004-10-13  H.J. Lu  <hongjiu.lu@intel.com>

	* ld-scripts/sort.exp: Run for ELF targets only.

--- ld/testsuite/ld-scripts/sort.exp.sec	2004-10-04 09:45:51.000000000 -0700
+++ ld/testsuite/ld-scripts/sort.exp	2004-10-13 11:44:20.753722581 -0700
@@ -17,6 +17,11 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
 
+# FIXME: The expected outputs are correct only for ELF.
+if ![is_elf_format] {
+    return
+}
+
 load_lib ld-lib.exp
 
 set sort_test_list [lsort [glob -nocomplain $srcdir/$subdir/sort*.d]]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: ld SORT_BY_* tests
  2004-10-13 18:48 ` H. J. Lu
@ 2004-10-14  8:53   ` Alan Modra
  0 siblings, 0 replies; 3+ messages in thread
From: Alan Modra @ 2004-10-14  8:53 UTC (permalink / raw)
  To: H. J. Lu; +Cc: binutils

On Wed, Oct 13, 2004 at 11:48:50AM -0700, H. J. Lu wrote:
> 	* ld-scripts/sort.exp: Run for ELF targets only.

Fair enough.  If people using other formats care enough, they might
fix the testsuite.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-10-14  8:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-11 11:03 ld SORT_BY_* tests Alan Modra
2004-10-13 18:48 ` H. J. Lu
2004-10-14  8:53   ` Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).