From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29547 invoked by alias); 11 Nov 2004 14:22:57 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 29400 invoked from network); 11 Nov 2004 14:22:42 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 11 Nov 2004 14:22:42 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CSFqP-0006lb-US; Thu, 11 Nov 2004 09:22:38 -0500 Date: Thu, 11 Nov 2004 14:22:00 -0000 From: Daniel Jacobowitz To: Nick Clifton Cc: binutils@sources.redhat.com, gdb-patches@sources.redhat.com, newlib@sources.redhat.com Subject: Re: Dejagnu: use -isystem to include system header files. Message-ID: <20041111142237.GA25841@nevyn.them.org> Mail-Followup-To: Nick Clifton , binutils@sources.redhat.com, gdb-patches@sources.redhat.com, newlib@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-11/txt/msg00187.txt.bz2 On Thu, Nov 11, 2004 at 11:58:15AM +0000, Nick Clifton wrote: > Hi Guys, > > I am going to check in the attached patch which imports a fix from > the mainline dejagnu sources. This fix is to use the -isystem > switch to include system header files rather than -I. This fixes > several unexpected failures in the GCC and G++ testsuites where the > newlib system header file is included in strict ANSI > mode, and the compiler barfs on the #include_next directive. This patch will break in-tree testing for yet other targets. I believe arm-elf was affected - anything which does not set NO_IMPLICIT_EXTERN_C. I discussed this with H-P on the dejagnu list but never figured out a solution, but... > * lib/libgloss.exp (newlib_include_flags): Use -isystem, not -I. > (libio_include_flags, g++_include_flags, libstdc++_include_flags, > winsup_include_flags): Ditto. ... I strongly suspect that g++ and winsup should be left out. -- Daniel Jacobowitz