From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-36463-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 32372 invoked by alias); 15 Nov 2004 03:48:56 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 32353 invoked from network); 15 Nov 2004 03:48:51 -0000
Received: from unknown (HELO gizmo04ps.bigpond.com) (144.140.71.14)
  by sourceware.org with SMTP; 15 Nov 2004 03:48:51 -0000
Received: (qmail 32698 invoked from network); 15 Nov 2004 03:48:49 -0000
Received: from unknown (HELO psmam12.bigpond.com) (144.135.25.103)
  by gizmo04ps.bigpond.com with SMTP; 15 Nov 2004 03:48:49 -0000
Received: from cpe-144-136-221-26.sa.bigpond.net.au ([144.136.221.26]) by psmam12.bigpond.com(MAM REL_3_4_2a 234/5978892) with SMTP id 5978892; Mon, 15 Nov 2004 13:48:49 +1000
Received: by bubble.modra.org (Postfix, from userid 500)
	id 28EC4136F96; Mon, 15 Nov 2004 14:18:49 +1030
Date: Mon, 15 Nov 2004 03:48:00 -0000
From: Alan Modra <amodra@bigpond.net.au>
To: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Cc: binutils@sources.redhat.com
Subject: Re: Ping: [RFA:] .error "msg" and .warning "msg" directives.
Message-ID: <20041115034849.GJ32175@bubble.modra.org>
Mail-Followup-To: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>,
	binutils@sources.redhat.com
References: <200411121043.iACAhbEu013681@ignucius.se.axis.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200411121043.iACAhbEu013681@ignucius.se.axis.com>
User-Agent: Mutt/1.4i
X-SW-Source: 2004-11/txt/msg00218.txt.bz2

On Fri, Nov 12, 2004 at 11:43:37AM +0100, Hans-Peter Nilsson wrote:
> Ping: <URL:http://sourceware.org/ml/binutils/2004-11/msg00064.html>.

> +   char *msg = err
> +     ? _(".error directive invoked in source file")
> +     : _(".warning directive invoked in source file");

No need to internationalize the directive (and parens needed before
err for proper formatting).

  char *msg = _("%s directive invoked in source file");
.
.
  if (err)
    as_bad (msg, ".error");
  else
    as_warn (msg, ".warning");

OK with that change.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre