From: "H. J. Lu" <hjl@lucon.org>
To: binutils@sources.redhat.com
Cc: jbeulich@novell.com
Subject: Re: [PATCH] some x86 instructions tagged with incorrect CPU type
Date: Tue, 16 Nov 2004 19:40:00 -0000 [thread overview]
Message-ID: <20041116194030.GA8857@lucon.org> (raw)
In-Reply-To: <20041115043500.GM32175@bubble.modra.org>
On Mon, Nov 15, 2004 at 03:05:00PM +1030, Alan Modra wrote:
> On Thu, Nov 04, 2004 at 11:20:37AM +0100, Jan Beulich wrote:
> > Various instructions where not tagged with the right required feature
> > set
> > identifiers, and some CPUs had by default features enabled which they
> > don't
> > always provide. This tries to rectify this. Additionally, it provides
> > the
> > ability to add certain feature groups to the user selected CPU (i.e.
> > MMX
> > instructions with a Pentium CPU).
>
> HJ, would you please review this patch? I figure you have more of a
> vested interest in x86 these days than I do..
>
The first problem is the patched assemebler failed "make check" for
x86-64. I got
/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:
Assembler messages:
/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3: Warning: `aaa' is not supported in 64-bit mode
/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3: Error: suffix or operands invalid for `aaa'
instead of
/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:
Assembler messages:
/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3: Error: suffix or operands invalid for `aaa'
I would prefer just
/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:
Assembler messages:
/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3: Error: `aaa' is not supported in 64-bit mode
H.J.
next prev parent reply other threads:[~2004-11-16 19:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-04 10:20 Jan Beulich
2004-11-15 4:35 ` Alan Modra
2004-11-16 19:40 ` H. J. Lu [this message]
2004-11-18 16:32 Jan Beulich
2004-11-19 19:33 ` H. J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041116194030.GA8857@lucon.org \
--to=hjl@lucon.org \
--cc=binutils@sources.redhat.com \
--cc=jbeulich@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).