From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18207 invoked by alias); 17 Nov 2004 17:05:43 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 18169 invoked from network); 17 Nov 2004 17:05:39 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 17 Nov 2004 17:05:39 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CUTFO-0000Kg-P4; Wed, 17 Nov 2004 12:05:34 -0500 Date: Wed, 17 Nov 2004 17:05:00 -0000 From: Daniel Jacobowitz To: Richard Earnshaw Cc: binutils@sources.redhat.com, Paul Brook Subject: Re: RFA: Support for Thumb in dynamic objects Message-ID: <20041117170534.GA1189@nevyn.them.org> Mail-Followup-To: Richard Earnshaw , binutils@sources.redhat.com, Paul Brook References: <20041116233909.GA31434@nevyn.them.org> <1100699286.22014.14.camel@pc960.cambridge.arm.com> <20041117164853.GA512@nevyn.them.org> <1100710750.22014.50.camel@pc960.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1100710750.22014.50.camel@pc960.cambridge.arm.com> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-11/txt/msg00254.txt.bz2 On Wed, Nov 17, 2004 at 04:59:10PM +0000, Richard Earnshaw wrote: > On Wed, 2004-11-17 at 16:48, Daniel Jacobowitz wrote: > > On Wed, Nov 17, 2004 at 01:48:06PM +0000, Richard Earnshaw wrote: > > > > OK? Comments? > > > > > > This is OK once you've addressed the point Paul raised. You might also > > > have to look at the tests when run in big-endian mode too. > > > > I missed some arm-elf vs arm-linux issues, and some big vs little > > endian issues; no one's run the testsuite in big-endian in a while. > > I'm reposting for review. There are two changes in the patch that I > > would like someone else to look at: > > > > - I fixed a big-endian Thumb disassembly bug. It would read past > > the end of the section. > > Can you use a macro rather than ~0x3? I just copied it from a couple of lines up. How about: ROUND_DOWN (pc + 4, 4) instead? -- Daniel Jacobowitz