From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8591 invoked by alias); 19 Nov 2004 11:57:03 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 8531 invoked from network); 19 Nov 2004 11:56:58 -0000 Received: from unknown (HELO gizmo10ps.bigpond.com) (144.140.71.20) by sourceware.org with SMTP; 19 Nov 2004 11:56:58 -0000 Received: (qmail 22044 invoked from network); 19 Nov 2004 11:56:56 -0000 Received: from unknown (HELO psmam12.bigpond.com) (144.135.25.103) by gizmo10ps.bigpond.com with SMTP; 19 Nov 2004 11:56:56 -0000 Received: from cpe-144-136-221-26.sa.bigpond.net.au ([144.136.221.26]) by psmam12.bigpond.com(MAM REL_3_4_2a 234/10571163) with SMTP id 10571163; Fri, 19 Nov 2004 21:56:56 +1000 Received: by bubble.modra.org (Postfix, from userid 500) id 2EE1710C0E8; Fri, 19 Nov 2004 22:26:56 +1030 Date: Fri, 19 Nov 2004 11:57:00 -0000 From: Alan Modra To: binutils@sources.redhat.com Subject: bfd warning fixes Message-ID: <20041119115656.GA7749@bubble.modra.org> Mail-Followup-To: binutils@sources.redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4i X-SW-Source: 2004-11/txt/msg00283.txt.bz2 * elf32-arm.c (elf32_arm_finish_dynamic_sections): Warning fix. * elf32-iq2000.c (iq2000_reloc_type_lookup): C90 function decl. * nlmcode.h (nlm_write_object_contents): Warning fix. Index: bfd/elf32-arm.c =================================================================== RCS file: /cvs/src/src/bfd/elf32-arm.c,v retrieving revision 1.9 diff -u -p -r1.9 elf32-arm.c --- bfd/elf32-arm.c 17 Nov 2004 17:50:23 -0000 1.9 +++ bfd/elf32-arm.c 19 Nov 2004 11:02:39 -0000 @@ -5314,8 +5314,8 @@ elf32_arm_finish_dynamic_sections (bfd * if (dyn.d_tag == DT_RELSZ || dyn.d_tag == DT_RELASZ) dyn.d_un.d_val += hdr->sh_size; - else if (dyn.d_un.d_val == 0 - || hdr->sh_offset < dyn.d_un.d_val) + else if ((ufile_ptr) hdr->sh_offset + <= dyn.d_un.d_val - 1) dyn.d_un.d_val = hdr->sh_offset; } } Index: bfd/elf32-iq2000.c =================================================================== RCS file: /cvs/src/src/bfd/elf32-iq2000.c,v retrieving revision 1.9 diff -u -p -r1.9 elf32-iq2000.c --- bfd/elf32-iq2000.c 2 Nov 2004 12:52:32 -0000 1.9 +++ bfd/elf32-iq2000.c 19 Nov 2004 11:02:39 -0000 @@ -330,9 +330,8 @@ iq2000_elf_relocate_hi16 (bfd *input_bfd } static reloc_howto_type * -iq2000_reloc_type_lookup (abfd, code) - bfd * abfd ATTRIBUTE_UNUSED; - bfd_reloc_code_real_type code; +iq2000_reloc_type_lookup (bfd *abfd ATTRIBUTE_UNUSED, + bfd_reloc_code_real_type code) { /* Note that the iq2000_elf_howto_table is indxed by the R_ constants. Thus, the order that the howto records appear in the Index: bfd/nlmcode.h =================================================================== RCS file: /cvs/src/src/bfd/nlmcode.h,v retrieving revision 1.12 diff -u -p -r1.12 nlmcode.h --- bfd/nlmcode.h 24 Jun 2004 04:46:25 -0000 1.12 +++ bfd/nlmcode.h 19 Nov 2004 11:02:50 -0000 @@ -1692,7 +1692,7 @@ nlm_write_object_contents (abfd) /* A weak check on whether the section file positions were reasonable. */ - if (bfd_tell (abfd) > (ufile_ptr) nlm_fixed_header (abfd)->codeImageOffset) + if (bfd_tell (abfd) > nlm_fixed_header (abfd)->codeImageOffset) { bfd_set_error (bfd_error_invalid_operation); goto error_return; -- Alan Modra IBM OzLabs - Linux Technology Centre