From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19542 invoked by alias); 19 Nov 2004 12:33:55 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 19514 invoked from network); 19 Nov 2004 12:33:46 -0000 Received: from unknown (HELO gizmo08bw.bigpond.com) (144.140.70.18) by sourceware.org with SMTP; 19 Nov 2004 12:33:46 -0000 Received: (qmail 31892 invoked from network); 19 Nov 2004 12:33:45 -0000 Received: from unknown (HELO bwmam12.bigpond.com) (144.135.24.103) by gizmo08bw.bigpond.com with SMTP; 19 Nov 2004 12:33:45 -0000 Received: from cpe-144-136-221-26.sa.bigpond.net.au ([144.136.221.26]) by bwmam12.bigpond.com(MAM REL_3_4_2a 189/11257233) with SMTP id 11257233; Fri, 19 Nov 2004 22:33:45 +1000 Received: by bubble.modra.org (Postfix, from userid 500) id CA49713EA07; Fri, 19 Nov 2004 23:03:44 +1030 Date: Fri, 19 Nov 2004 12:33:00 -0000 From: Alan Modra To: binutils@sources.redhat.com Subject: maxq warning fix Message-ID: <20041119123344.GE7749@bubble.modra.org> Mail-Followup-To: binutils@sources.redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4i X-SW-Source: 2004-11/txt/msg00287.txt.bz2 This is a bit of a guess on my part, but what was in the line 682 hunk below is obviously wrong. * maxq-dis.c: Formatting. (print_insn): Warning fix. Index: opcodes/maxq-dis.c =================================================================== RCS file: /cvs/src/src/opcodes/maxq-dis.c,v retrieving revision 1.1 diff -u -p -r1.1 maxq-dis.c --- opcodes/maxq-dis.c 8 Nov 2004 13:17:37 -0000 1.1 +++ opcodes/maxq-dis.c 19 Nov 2004 11:04:30 -0000 @@ -358,8 +358,8 @@ get_group (const unsigned int insn) if ((insn & _DECODE_LOWNIB_HIGHBYTE) == 0x0A00) { - /* && condition with sec part added on 26 May for resoveing 2 & 3 grp - conflict. */ + /* && condition with sec part added on 26 May for resolving 2 & 3 grp + conflict. */ if (((insn & _DECODE_LOWNIB_LOWBYTE) == 0x000A) && ((insn & _DECODE_GET_F_HIGHBYTE) == 0x8000)) { @@ -652,7 +652,8 @@ print_insn (bfd_vma memaddr, struct disa grp.bit_no); } else - info->fprintf_func (info->stream, " %s", get_reg_name (grp.dst, (type1) 0)); + info->fprintf_func (info->stream, " %s", + get_reg_name (grp.dst, (type1) 0)); } /* SRC is ABSENT in the grp. */ @@ -682,7 +683,7 @@ print_insn (bfd_vma memaddr, struct disa grp.bit_no); if (format == 0) info->fprintf_func (info->stream, " #%02xh.%d", - (grp.src, SRC), grp.bit_no); + grp.src, grp.bit_no); } else { @@ -692,11 +693,11 @@ print_insn (bfd_vma memaddr, struct disa format = grp.fbit; if (format == 1) info->fprintf_func (info->stream, " %s", - get_reg_name (grp.src, - (type1) 1 /*SRC*/)); + get_reg_name (grp.src, + (type1) 1 /*SRC*/)); if (format == 0) info->fprintf_func (info->stream, " #%02xh", - (grp.src)); + (grp.src)); } } @@ -705,7 +706,7 @@ print_insn (bfd_vma memaddr, struct disa } info->fprintf_func (info->stream, "Unable to Decode : %02x %02x", - insn[0], insn[1]); + insn[0], insn[1]); return 2; } @@ -714,4 +715,3 @@ print_insn_maxq_little (bfd_vma memaddr, { return print_insn (memaddr, info, BFD_ENDIAN_LITTLE); } - -- Alan Modra IBM OzLabs - Linux Technology Centre