From: "H. J. Lu" <hjl@lucon.org>
To: Jan Beulich <JBeulich@novell.com>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] some x86 instructions tagged with incorrect CPU type
Date: Fri, 19 Nov 2004 19:33:00 -0000 [thread overview]
Message-ID: <20041119193333.GA19498@lucon.org> (raw)
In-Reply-To: <s19cce7b.005@emea1-mh.id2.novell.com>
On Thu, Nov 18, 2004 at 05:33:08PM +0100, Jan Beulich wrote:
> >>> "H. J. Lu" <hjl@lucon.org> 16.11.04 20:40:30 >>>
> >The first problem is the patched assemebler failed "make check" for
> >x86-64. I got
>
> >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:
> >Assembler messages:
> >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3:
> Warning: `aaa' is not supported in 64-bit mode
> >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3:
> Error: suffix or operands invalid for `aaa'
> >
> >instead of
> >
> >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:
> >Assembler messages:
> >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3:
> Error: suffix or operands invalid for `aaa'
> >
> >I would prefer just
> >
> >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:
> >Assembler messages:
> >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3:
> Error: `aaa' is not supported in 64-bit mode
>
> This is easily fixed, as below/attached. Built/tested on
> i686-pc-linux-gnu
> (this time also as cross assembler targeting
> x86_64-unknown-linux-gnu).
> Despite finding this more desirable, too, I didn't originally dare to
> make
> these errors because they weren't before.
>
This is OK. Please apply.
Thanks.
H.J.
next prev parent reply other threads:[~2004-11-19 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-18 16:32 Jan Beulich
2004-11-19 19:33 ` H. J. Lu [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-11-04 10:20 Jan Beulich
2004-11-15 4:35 ` Alan Modra
2004-11-16 19:40 ` H. J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041119193333.GA19498@lucon.org \
--to=hjl@lucon.org \
--cc=JBeulich@novell.com \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).