From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6374 invoked by alias); 19 Nov 2004 19:33:39 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 6345 invoked from network); 19 Nov 2004 19:33:35 -0000 Received: from unknown (HELO rwcrmhc12.comcast.net) (216.148.227.85) by sourceware.org with SMTP; 19 Nov 2004 19:33:35 -0000 Received: from lucon.org ([24.6.212.230]) by comcast.net (rwcrmhc12) with ESMTP id <2004111919333401400ae8rqe>; Fri, 19 Nov 2004 19:33:34 +0000 Received: by lucon.org (Postfix, from userid 1000) id EC69D6405F; Fri, 19 Nov 2004 11:33:33 -0800 (PST) Date: Fri, 19 Nov 2004 19:33:00 -0000 From: "H. J. Lu" To: Jan Beulich Cc: binutils@sources.redhat.com Subject: Re: [PATCH] some x86 instructions tagged with incorrect CPU type Message-ID: <20041119193333.GA19498@lucon.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i X-SW-Source: 2004-11/txt/msg00295.txt.bz2 On Thu, Nov 18, 2004 at 05:33:08PM +0100, Jan Beulich wrote: > >>> "H. J. Lu" 16.11.04 20:40:30 >>> > >The first problem is the patched assemebler failed "make check" for > >x86-64. I got > > >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s: > >Assembler messages: > >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3: > Warning: `aaa' is not supported in 64-bit mode > >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3: > Error: suffix or operands invalid for `aaa' > > > >instead of > > > >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s: > >Assembler messages: > >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3: > Error: suffix or operands invalid for `aaa' > > > >I would prefer just > > > >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s: > >Assembler messages: > >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3: > Error: `aaa' is not supported in 64-bit mode > > This is easily fixed, as below/attached. Built/tested on > i686-pc-linux-gnu > (this time also as cross assembler targeting > x86_64-unknown-linux-gnu). > Despite finding this more desirable, too, I didn't originally dare to > make > these errors because they weren't before. > This is OK. Please apply. Thanks. H.J.