public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Ian Lance Taylor <ian@wasabisystems.com>
To: binutils@sourceware.org
Subject: Increment size of relax sequence if we emit a nop
Date: Thu, 09 Dec 2004 15:51:00 -0000	[thread overview]
Message-ID: <20041209155111.10502.qmail@gossamer.airs.com> (raw)

While experimenting with some code that I didn't check in, I noticed a
minor issue.  If we insert a nop while processing a relax sequence, we
weren't accounting for the size of the inserted nop.  This led to
confusing errors later on.  This patch should be harmless for existing
relaxation sequences, but may make future ones a little easier to
handle.  I'm about to commit it.

Ian


2004-12-09  Ian Lance Taylor  <ian@wasabisystems.com>

	* config/tc-mips.c (append_insn): If we emit a nop during a relax
	sequence, increase the size of the sequence.


Index: config/tc-mips.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-mips.c,v
retrieving revision 1.275
diff -u -r1.275 tc-mips.c
--- config/tc-mips.c	9 Dec 2004 06:17:14 -0000	1.275
+++ config/tc-mips.c	9 Dec 2004 15:47:41 -0000
@@ -2542,6 +2542,8 @@
 		 instruction at the destination, put it in the delay
 		 slot, and bump the destination address.  */
 	      emit_nop ();
+	      if (mips_relax.sequence)
+		mips_relax.sizes[mips_relax.sequence - 1] += 4;
 	      /* Update the previous insn information.  */
 	      prev_prev_insn = *ip;
 	      prev_insn.insn_mo = &dummy_opcode;

             reply	other threads:[~2004-12-09 15:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-09 15:51 Ian Lance Taylor [this message]
2004-12-09 16:38 ` Richard Sandiford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041209155111.10502.qmail@gossamer.airs.com \
    --to=ian@wasabisystems.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).