From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30205 invoked by alias); 18 Dec 2004 00:49:42 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 30107 invoked from network); 18 Dec 2004 00:49:27 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 18 Dec 2004 00:49:27 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id iBI0nRFm002490 for ; Fri, 17 Dec 2004 19:49:27 -0500 Received: from post-office.corp.redhat.com (post-office.corp.redhat.com [172.16.52.227]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iBI0nRr15956; Fri, 17 Dec 2004 19:49:27 -0500 Received: from greed.delorie.com (dj.cipe.redhat.com [10.0.0.222]) by post-office.corp.redhat.com (8.11.6/8.11.6) with ESMTP id iBI0nQ801383; Fri, 17 Dec 2004 19:49:26 -0500 Received: from greed.delorie.com (localhost [127.0.0.1]) by greed.delorie.com (8.12.11/8.12.10) with ESMTP id iBI0nPxE013116; Fri, 17 Dec 2004 19:49:25 -0500 Received: (from dj@localhost) by greed.delorie.com (8.12.11/8.12.11/Submit) id iBI0nPAI013112; Fri, 17 Dec 2004 19:49:25 -0500 Date: Sat, 18 Dec 2004 00:49:00 -0000 Message-Id: <200412180049.iBI0nPAI013112@greed.delorie.com> From: DJ Delorie To: hjl@lucon.org CC: binutils@sources.redhat.com, gcc-patches@gcc.gnu.org In-reply-to: <20041218002144.GA6908@lucon.org> (hjl@lucon.org) Subject: Re: PATCH: Fix shared library build for libiberty References: <20041216230100.GA16067@lucon.org> <200412170200.iBH20euE027630@greed.delorie.com> <20041217020757.GA18875@lucon.org> <200412170210.iBH2Afpl027782@greed.delorie.com> <20041217052058.GA21455@lucon.org> <20041217154126.GA31731@lucon.org> <200412171747.iBHHlp5E003347@greed.delorie.com> <20041218002144.GA6908@lucon.org> X-SW-Source: 2004-12/txt/msg00216.txt.bz2 > * configure.in (WIN32LIBADD): Use -L../libiberty/.libs instead > of -L../libiberty/pic. Oh crap, this is bad. Can we arrange for both the old way and the new way to work? I don't want to become incompatible with other modules if I don't have to, as libiberty is used all over the place and coordinating the needed changes would be a mess. > (AC_PROG_CC_C_O): Removed. > (OUTPUT_OPTION): Removed. > (NO_MINUS_C_MINUS_O): Removed. Could you explain why? > COMPILE.c = $(CC) -c @DEFS@ $(LIBCFLAGS) -I. -I$(INCDIR) $(HDEFINES) @ac_libiberty_warn_cflags@ > +LTCOMPILE = $(LIBTOOL) --mode=compile $(COMPILE.c) > + > +.c.lo: > + $(LTCOMPILE) -c -o $@ $< > > # Just to make sure we don't use a built-in rule with VPATH > .c.o: > false If you read the .c.o comment, you'll see that the .c.lo rule must also be "false". This is the vpath problem I was talking about - the .c.lo rule causes in-srcdir builds to link the wrong objects if the other rules don't happen to match. > +# (alphabetical), and add them to REQUIRED_OFILES/REQUIRED_LTOFILES, or > +# CONFIGURED_OFILES/CONFIGURED_LTOFILES and funcs in configure.ac. Sigh, too bad we can't automate this, but we can't use gnumake yet. Hmmm... I wonder if maint-tool can be tweaked to use one of the lists to update the others? At least it will occasionally fix any inconsistencies. (Don't do this yet! One thing at a time.) > +# Also run "make maint-deps" to build the new rules. Good idea to add this comment.