public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@gnu.org>
To: amodra@bigpond.net.au, ezannoni@redhat.com
Cc: binutils@sources.redhat.com, gdb@sources.redhat.com
Subject: Re: Giving canonical sections a name breaks GDB?
Date: Tue, 21 Dec 2004 20:28:00 -0000	[thread overview]
Message-ID: <200412212027.iBLKRe7L000687@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <20041220223449.GA13749@bubble.modra.org> (message from Alan Modra on Tue, 21 Dec 2004 09:04:49 +1030)

   Date: Tue, 21 Dec 2004 09:04:49 +1030
   From: Alan Modra <amodra@bigpond.net.au>

   On Mon, Dec 20, 2004 at 01:41:12PM +0100, Mark Kettenis wrote:
   > Any idea what's wrong?

   Try this

	   * elfread.c (elf_symtab_read): Discard section syms.

Thanks, yes, that solves the problem.  Elena, is this ok?  Perhaps it
needs a comment?

Mark


Index: gdb/elfread.c
===================================================================
RCS file: /cvs/src/src/gdb/elfread.c,v
retrieving revision 1.47
diff -u -p -r1.47 elfread.c
--- gdb/elfread.c	23 Oct 2004 16:18:08 -0000	1.47
+++ gdb/elfread.c	20 Dec 2004 22:34:20 -0000
@@ -254,6 +254,8 @@ elf_symtab_read (struct objfile *objfile
 			      &objfile->objfile_obstack);
 #endif
 	    }
+	  else if (sym->flags & BSF_SECTION_SYM)
+	    continue;
 	  else if (sym->flags & (BSF_GLOBAL | BSF_LOCAL | BSF_WEAK))
 	    {
 	      struct minimal_symbol *msym;

  reply	other threads:[~2004-12-21 20:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-20 12:41 Mark Kettenis
2004-12-20 22:35 ` Alan Modra
2004-12-21 20:28   ` Mark Kettenis [this message]
2004-12-30 22:32     ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200412212027.iBLKRe7L000687@elgar.sibelius.xs4all.nl \
    --to=kettenis@gnu.org \
    --cc=amodra@bigpond.net.au \
    --cc=binutils@sources.redhat.com \
    --cc=ezannoni@redhat.com \
    --cc=gdb@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).