From: Alan Modra <amodra@bigpond.net.au>
To: Kris Warkentin <kewarken@qnx.com>
Cc: binutils@sources.redhat.com
Subject: Re: [patch] (OB?) Fix for QNX Neutrino core file floating point handler
Date: Wed, 22 Dec 2004 04:34:00 -0000 [thread overview]
Message-ID: <20041222043445.GB18274@bubble.modra.org> (raw)
In-Reply-To: <41C8A4E2.8070900@qnx.com>
On Tue, Dec 21, 2004 at 05:34:10PM -0500, Kris Warkentin wrote:
> * elf.c (elfcore_grok_nto_gregs): Change name to ..._nto_regs.
Minor nit. Please specify the complete new function name here, so that
you can search for it in the ChangeLog. (It's minor because a search
would hit the instance below.)
> Add 'base' argument for constructing register sections.
> Reformat.
> (elfcore_grok_nto_note): Call elfcore_grok_nto_regs for both
> gp and fp regs. Reformat.
OK with the above change, and the indentation below fixed.
> + case BFD_QNT_CORE_INFO:
> + return elfcore_make_note_pseudosection (abfd, ".qnx_core_info", note);
> + case BFD_QNT_CORE_STATUS:
> + return elfcore_grok_nto_status (abfd, note, &tid);
--
Alan Modra
IBM OzLabs - Linux Technology Centre
next prev parent reply other threads:[~2004-12-22 4:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-21 22:34 Kris Warkentin
2004-12-22 4:34 ` Alan Modra [this message]
2004-12-22 14:45 ` Commited:[patch] (OB?) Fix for QNX Neutrino core file floating point h andler Kris Warkentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041222043445.GB18274@bubble.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sources.redhat.com \
--cc=kewarken@qnx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).