From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28034 invoked by alias); 22 Dec 2004 04:34:56 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 27967 invoked from network); 22 Dec 2004 04:34:48 -0000 Received: from unknown (HELO gizmo02bw.bigpond.com) (144.140.70.12) by sourceware.org with SMTP; 22 Dec 2004 04:34:48 -0000 Received: (qmail 18296 invoked from network); 22 Dec 2004 04:34:46 -0000 Received: from unknown (HELO bwmam12.bigpond.com) (144.135.24.103) by gizmo02bw.bigpond.com with SMTP; 22 Dec 2004 04:34:46 -0000 Received: from cpe-144-136-221-26.sa.bigpond.net.au ([144.136.221.26]) by bwmam12.bigpond.com(MAM REL_3_4_2a 189/18225090) with SMTP id 18225090; Wed, 22 Dec 2004 14:34:46 +1000 Received: by bubble.modra.org (Postfix, from userid 500) id 246CF14C075; Wed, 22 Dec 2004 15:04:46 +1030 Date: Wed, 22 Dec 2004 04:34:00 -0000 From: Alan Modra To: Kris Warkentin Cc: binutils@sources.redhat.com Subject: Re: [patch] (OB?) Fix for QNX Neutrino core file floating point handler Message-ID: <20041222043445.GB18274@bubble.modra.org> Mail-Followup-To: Kris Warkentin , binutils@sources.redhat.com References: <41C8A4E2.8070900@qnx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41C8A4E2.8070900@qnx.com> User-Agent: Mutt/1.4i X-SW-Source: 2004-12/txt/msg00273.txt.bz2 On Tue, Dec 21, 2004 at 05:34:10PM -0500, Kris Warkentin wrote: > * elf.c (elfcore_grok_nto_gregs): Change name to ..._nto_regs. Minor nit. Please specify the complete new function name here, so that you can search for it in the ChangeLog. (It's minor because a search would hit the instance below.) > Add 'base' argument for constructing register sections. > Reformat. > (elfcore_grok_nto_note): Call elfcore_grok_nto_regs for both > gp and fp regs. Reformat. OK with the above change, and the indentation below fixed. > + case BFD_QNT_CORE_INFO: > + return elfcore_make_note_pseudosection (abfd, ".qnx_core_info", note); > + case BFD_QNT_CORE_STATUS: > + return elfcore_grok_nto_status (abfd, note, &tid); -- Alan Modra IBM OzLabs - Linux Technology Centre